Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): rename "Created after" to "Sent out" #27570

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(notifications): rename "Created after" to "Sent out" #27570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-steaks-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage/plugin-notifications': patch
---

The "Created after" filter renamed to the "Sent out" based on the received users' feedback.
6 changes: 2 additions & 4 deletions plugins/notifications/src/components/NotificationsFilters/NotificationsFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,10 @@ export const NotificationsFilters = ({

<Grid item xs={12}>
<FormControl fullWidth variant="outlined" size="small">
<InputLabel id="notifications-filter-created">
Created after
</InputLabel>
<InputLabel id="notifications-filter-created">Sent out</InputLabel>

<Select
label="Created after"
label="Sent out"
labelId="notifications-filter-created"
placeholder="Notifications since"
value={createdAfter}
Expand Down