Skip to content

Commit

Permalink
Bugfix: Fix ingress error causing spec and Rules to be on single line (
Browse files Browse the repository at this point in the history
…#22)

* [Bugfix] Fix ingress issue defined in issue 21

Why do we need this change?
=======================
Introduced recently in the TLS section is the {{- end -}} where we suppress the newline. This causes the rules to end up on the same line as the previous section and would break the schema and get something like spec:rules: which is invalid

What effects does this change have?
=======================
Changes the {{- end -}} for the TLS section of the ingress to not suppress the newline

* Bump version of the chart as needed
  • Loading branch information
JoshuaJackson-jobvite authored Dec 10, 2022
1 parent 29d69af commit 1648c10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.6.1
version: 0.6.2

dependencies:
- name: common
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
- hosts:
- {{ .Values.ingress.host }}
secretName: {{ .Values.ingress.tls.secretName }}
{{- end -}}
{{- end }}
rules:
- host: {{ .Values.ingress.host }}
http:
Expand Down

0 comments on commit 1648c10

Please sign in to comment.