Bugfix: Fix ingress error causing spec and Rules to be on single line #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do we need this change?
=======================
Introduced recently in the TLS section is the {{- end -}} where we suppress the newline. This causes the rules to end up on the same line as the previous section and would break the schema and get something like spec:rules: which is invalid
What effects does this change have?
=======================
Changes the {{- end -}} for the TLS section of the ingress to not suppress the newline
JoshuaJackson-jobvite
changed the title
JoshuaJackson-jobvite
changed the title
tumido
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
Sigh, this is on me, I let it slip after a rebase here.
Thank you for the fix @JoshuaJackson-jobvite 1🙌
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Introduced recently in the TLS section is the {{- end -}} where we suppress the newline. This causes the rules to end up on the same line as the previous section and would break the schema and get something like spec:rules: which is invalid
Changes the {{- end -}} for the TLS section of the ingress to not suppress the newline
Existing or Associated Issue(s)
Fixes: #21
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.