Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #24

Closed
nikolaik opened this issue Dec 12, 2022 · 7 comments · Fixed by #50
Closed

Changelog #24

nikolaik opened this issue Dec 12, 2022 · 7 comments · Fixed by #50

Comments

@nikolaik
Copy link
Contributor

nikolaik commented Dec 12, 2022

Awesome work and great to see all the improvements to the repo!

I would love to see formatted changelogs for releases, like a list of merged PRs, to quickly spot any potential breaking changes. Especially since they can happen pretty frequent in the 0.x.x time of development

@ChrisJBurns
Copy link
Contributor

Hi @nikolaik I wonder whether it is worth it? The way the repository has been set up is that on every PR merge to main, the release flow is triggered. So there is only ever one PR (theoretically) that goes out with every release, instead of a release being made up of multiple PR's.

I agree, it would be beneficial to link the PR itself to the release notes, however, it may have to be a manual effort that's needed as to automate this would be a bit of an effort - for very little pay off.

@nikolaik
Copy link
Contributor Author

nikolaik commented Jan 4, 2023

Hi @ChrisJBurns totally agree that using too much effort on this is not worth it. If helm/chart-releaser#229 or similar functionality is merged to helm's chart-releaser, could using automatic changelogs from GitHub be an option?

@ChrisJBurns
Copy link
Contributor

ChrisJBurns commented Jan 4, 2023

Something like that would be great (does depend on the ease of use though)! It will mean that one more thing is added to every PR, but I think it's not the end of the world, especially as it allows for users to see what's changed in the releases page. So either way, time is being saved for someone

tumido pushed a commit that referenced this issue Jan 11, 2023
@ChrisJBurns
Copy link
Contributor

@nikolaik @tumido Could we possibly add something that describes what a contributor has to do to get the release notes to be generated? Whether it's in the PR template or a contribution docs, what do you think?

@tumido
Copy link
Member

tumido commented Jan 11, 2023

I'm sorry, I'm not sure I fully understand. As far as I know, the change introduced in #50 is tapping into the GitHub's (now) native automatic release note generator. So all that user has to do, is to provide a PR title. And that is not really a change, this was always needed. Or did I miss something?

@nikolaik
Copy link
Contributor Author

I believe that is what is supposed to happen aswell. chart-releaser uses this GitHub API to create a release with the generate_release_notes option set, which should populate the release with a body according to these docs

@ChrisJBurns
Copy link
Contributor

Ahh, was my misunderstanding then :) I mistakenly assumed there'd be a release for the merge of PR but then just realised that nothing technically got released in the time this PR got merged. Ignore me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants