Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Generate release notes #50

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

nikolaik
Copy link
Contributor

Start using the flag introduced in https://github.com/helm/chart-releaser/releases/tag/v1.5.0 which relies on GitHub to generate release notes automatically.

Resolves #24

@nikolaik nikolaik requested a review from a team as a code owner January 11, 2023 07:28
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a great addition, thank you! LGTM ❤️

@tumido
Copy link
Member

tumido commented Jan 11, 2023

@nikolaik Unfortunately we're unable to merge your PR unless all commits are GPG signed. Can you please look into that? (Because we would love to have this in! 🙂 )

image

https://docs.github.com/articles/about-gpg/

@nikolaik nikolaik force-pushed the chore/release-notes branch from c5b91e5 to 986b9c0 Compare January 11, 2023 11:15
Start using the flag introduced in https://github.com/helm/chart-releaser/releases/tag/v1.5.0
which relies on GitHub to generate release notes automatically.
@nikolaik nikolaik force-pushed the chore/release-notes branch from 986b9c0 to df2673a Compare January 11, 2023 11:17
@nikolaik
Copy link
Contributor Author

@tumido Fixed now!

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tumido tumido merged commit 9b2769b into backstage:main Jan 11, 2023
@tumido tumido mentioned this pull request Jan 11, 2023
@nikolaik nikolaik deleted the chore/release-notes branch January 11, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog
2 participants