-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update markdown >3.2 and graphviz extension #74
Conversation
@camilaibs @iamEAP Could you please review and approve this? Merging this PR would allow folks to use other mkdocs plugins (like mkdocstrings) which only work with markdown >3.3 in conjunction with techdocs. |
Starting to review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed these steps for the integration test and everything went fine, thanks for contributing 🎉
If this PR is merged, then changes would have to be made to techdocs docs (notes section at the end) and techdocs-container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iswariyam I talked to @iamEAP and we're a little concerned about the open-endedness of themarkdown_inline_graphviz_extension
version constraint...
How about combining what we did with the markdown
constraint >=1.1.1,<2 or something?
Fine by me. I'll push the change. |
189f45c
to
f294521
Compare
f294521
to
98b90a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything more needed for my side for this to be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for contributing 🙌🏻
Summary:
Related to #37
Fixes #36 and #45 (allows users to use markdown >=3.3)