Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown >3.2 and graphviz extension #74

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

iswariyam
Copy link

@iswariyam iswariyam commented Jul 27, 2022

Summary:

  • Update markdown_inline_graphviz_extension to 1.1.1 as errors related to svg rendering is fixed in this PR
  • The latest version of markdown_inline_graphviz_extension is now compatible with markdown 3.3 and above

Related to #37
Fixes #36 and #45 (allows users to use markdown >=3.3)

@iswariyam iswariyam requested a review from a team as a code owner July 27, 2022 18:42
@iswariyam iswariyam changed the title chore: Update markdown >3.2 and graphviz extension Update markdown >3.2 and graphviz extension Jul 27, 2022
@iswariyam
Copy link
Author

@camilaibs @iamEAP Could you please review and approve this? Merging this PR would allow folks to use other mkdocs plugins (like mkdocstrings) which only work with markdown >3.3 in conjunction with techdocs.

@camilaibs
Copy link
Contributor

@camilaibs @iamEAP Could you please review and approve this? Merging this PR would allow folks to use other mkdocs plugins (like mkdocstrings) which only work with markdown >3.3 in conjunction with techdocs.

Starting to review 🙂

Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed these steps for the integration test and everything went fine, thanks for contributing 🎉

@iswariyam
Copy link
Author

If this PR is merged, then changes would have to be made to techdocs docs (notes section at the end) and techdocs-container

Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iswariyam I talked to @iamEAP and we're a little concerned about the open-endedness of themarkdown_inline_graphviz_extension version constraint...
How about combining what we did with the markdown constraint >=1.1.1,<2 or something?

@iswariyam
Copy link
Author

@iswariyam I talked to @iamEAP and we're a little concerned about the open-endedness of themarkdown_inline_graphviz_extension version constraint... How about combining what we did with the markdown constraint >=1.1.1,<2 or something?

Fine by me. I'll push the change.

@camilaibs camilaibs force-pushed the feature/markdown_3.3 branch from 189f45c to f294521 Compare July 29, 2022 09:02
@camilaibs camilaibs force-pushed the feature/markdown_3.3 branch from f294521 to 98b90a6 Compare July 29, 2022 09:21
Copy link
Author

@iswariyam iswariyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything more needed for my side for this to be merged?

Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for contributing 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphViz Diagrams are not rendering correctly in version 0.1.1
2 participants