-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize requirements.txt #92
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,23 @@ | ||
# The "base" version of the Mkdocs project. | ||
# https://github.com/mkdocs/mkdocs | ||
# The following are something akin to peer dependencies. They are represented | ||
# as ranges in order to support interoperability with other mkdocs plugins or | ||
# packages that might otherwise exist in an adopter's environment. | ||
mkdocs>=1.2.2 | ||
Markdown>=3.2,<3.4 | ||
|
||
# The following are more akin to direct dependencies. Each line represents one | ||
# or more features that are provided by `techdocs-core`, and thus are always | ||
# pinned to an exact version. Bumps should be accompanied by release notes | ||
# explaining what was added or fixed (or at least pointing to the underlying | ||
# release notes of the bumped package). | ||
mkdocs-material==8.1.11 | ||
mkdocs-monorepo-plugin~=1.0.1 | ||
mkdocs-monorepo-plugin==1.0.3 | ||
plantuml-markdown==3.5.1 | ||
markdown_inline_graphviz_extension>=1.1.1,<2.0 | ||
markdown_inline_graphviz_extension==1.1.1 | ||
mdx_truly_sane_lists==1.2 | ||
pygments==2.10 | ||
pymdown-extensions==9.3 | ||
Markdown>=3.2,<3.4 | ||
|
||
# The following are temporary dependencies that are only necessary to work | ||
# around incompatible/conflicting underlying dependencies. Each dependency | ||
# should include a comment explaining why it is needed, and under what | ||
# circumstances it can be removed in the future. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that
markdown_inline_graphviz_extension>=1.1.1,<2.0
was introduced as part of this PR #74 after this comment #74 (review)Before we merge this I just want to make sure this is not still a concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving the dependency from an extract version to a range was mistaken advice on my part in that PR. The hope is that splitting out the dependencies into these categories (as done in this PR) will help our future selves reason about ranges vs. exact versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree with that, just wanted to double check with you both around that specific comment! So lets 🚢 it!