Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize requirements.txt #92

Merged
merged 3 commits into from
Aug 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@ We only use `material-mkdocs` as base styles because Backstage also uses the `Ma

### Unreleased

- Removed pins on the `pyparsing` and `Jinja2` dependencies, which are no longer needed.
- Removed pins on the `pyparsing` and `Jinja2` dependencies, which are no
longer needed.
- Pinned `mkdocs-monorepo-plugin` and `markdown_inline_graphviz_extension` to
specific (latest) releases to improve stability. Going forward, these (along
with all other feature-related deps) will be bumped regularly and any changes
will be reflected in this changelog.

### 1.1.5

Expand Down
22 changes: 17 additions & 5 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
# The "base" version of the Mkdocs project.
# https://github.com/mkdocs/mkdocs
# The following are something akin to peer dependencies. They are represented
# as ranges in order to support interoperability with other mkdocs plugins or
# packages that might otherwise exist in an adopter's environment.
mkdocs>=1.2.2
Markdown>=3.2,<3.4

# The following are more akin to direct dependencies. Each line represents one
# or more features that are provided by `techdocs-core`, and thus are always
# pinned to an exact version. Bumps should be accompanied by release notes
# explaining what was added or fixed (or at least pointing to the underlying
# release notes of the bumped package).
mkdocs-material==8.1.11
mkdocs-monorepo-plugin~=1.0.1
mkdocs-monorepo-plugin==1.0.3
plantuml-markdown==3.5.1
markdown_inline_graphviz_extension>=1.1.1,<2.0
markdown_inline_graphviz_extension==1.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that markdown_inline_graphviz_extension>=1.1.1,<2.0 was introduced as part of this PR #74 after this comment #74 (review)

@iswariyam I talked to @iamEAP and we're a little concerned about the open-endedness of themarkdown_inline_graphviz_extension version constraint...
How about combining what we did with the markdown constraint >=1.1.1,<2 or something?

Before we merge this I just want to make sure this is not still a concern?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving the dependency from an extract version to a range was mistaken advice on my part in that PR. The hope is that splitting out the dependencies into these categories (as done in this PR) will help our future selves reason about ranges vs. exact versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree with that, just wanted to double check with you both around that specific comment! So lets 🚢 it!

mdx_truly_sane_lists==1.2
pygments==2.10
pymdown-extensions==9.3
Markdown>=3.2,<3.4

# The following are temporary dependencies that are only necessary to work
# around incompatible/conflicting underlying dependencies. Each dependency
# should include a comment explaining why it is needed, and under what
# circumstances it can be removed in the future.