Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade setup-ffmpeg + fix loudnorm failing on ffmpeg 6+ [BDGR-168] #468

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

markspolakovs
Copy link
Collaborator

@markspolakovs markspolakovs commented Jul 8, 2024

Fixes BDGR-168

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Warnings
⚠️

No Linear ticket found. Please include one in either the pull request title (e.g. [BDGR-123] Fix something), the description (Fixes BDGR-123.), or the branch name (bow-123-fix-something).

Generated by 🚫 dangerJS against 9ec2b90

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 22.16%. Comparing base (1678855) to head (9ec2b90).

Files Patch % Lines
jobrunner/src/jobs/ProcessMediaJob.ts 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   22.04%   22.16%   +0.12%     
==========================================
  Files          96       96              
  Lines        3602     3614      +12     
  Branches      605      604       -1     
==========================================
+ Hits          794      801       +7     
- Misses       2659     2812     +153     
+ Partials      149        1     -148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markspolakovs markspolakovs enabled auto-merge July 8, 2024 21:44
@markspolakovs markspolakovs added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@markspolakovs markspolakovs changed the title Upgrade setup-ffmpeg and pin to ffmpeg 5 Upgrade setup-ffmpeg + fix loudnorm failing on ffmpeg 6+ [BDGR-168] Jul 9, 2024
@markspolakovs markspolakovs added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 7221d33 Jul 9, 2024
14 checks passed
@markspolakovs markspolakovs deleted the ffmpeg-6-pin branch July 9, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants