Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BDGR-168] Fix jobrunner under newer versions of ffmpeg #469

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[BDGR-168] Fix jobrunner under newer versions of ffmpeg #469

merged 1 commit into from
Jul 8, 2024

Conversation

markspolakovs
Copy link
Collaborator

No description provided.

@markspolakovs markspolakovs changed the title Bdgr-168-jobrunner-broken-under-ffmpeg-60 [BDGR-168] Fix jobrunner under newer versions of ffmpeg Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Messages
📖

Removed TODOs: BDGR-168

Once merged, please close the corresponding Linear tickets.
You can also include Closes BDGR-168 in the PR description to close the tickets automatically.

Generated by 🚫 dangerJS against 190547e

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 22.16%. Comparing base (a113f88) to head (190547e).

Files Patch % Lines
jobrunner/src/jobs/ProcessMediaJob.ts 70.58% 5 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           ffmpeg-6-pin     #469      +/-   ##
================================================
+ Coverage         22.04%   22.16%   +0.12%     
================================================
  Files                96       96              
  Lines              3602     3614      +12     
  Branches            605      604       -1     
================================================
+ Hits                794      801       +7     
- Misses             2659     2664       +5     
  Partials            149      149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markspolakovs markspolakovs merged commit d009bc3 into ffmpeg-6-pin Jul 8, 2024
11 checks passed
@markspolakovs markspolakovs deleted the bdgr-168-jobrunner-broken-under-ffmpeg-60 branch July 8, 2024 21:52
markspolakovs added a commit that referenced this pull request Jul 8, 2024
@markspolakovs
Revert "[BDGR-168] Fix jobrunner under newer versions of ffmpeg (#469)"
33447fe 
This reverts commit d009bc3.
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2024
@markspolakovs
Upgrade setup-ffmpeg + fix loudnorm failing on ffmpeg 6+ [BDGR-168] (#…
7221d33 
…468)

* Upgrade setup-ffmpeg and pin to ffmpeg 5

* Pin ffmpeg correctly

* [BDGR-168] Fix jobrunner under newer versions of ffmpeg (#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markspolakovs @codecov-commenter