-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower badge shows void instead of alpha #1098
Comments
Hi, this is for your package on pre-release version. (not stable version). I've made a PR #1099 on it. |
Seems like there is also a usability issue here. Instead of displaying void when there are no releases, we should display something more user-friendly, like no releases. @ritwickdey Maybe you could test that case in your pull request, possibly using a mocked server response, and add a fix. |
Hi @paulmelnikow , I've made changes & added 9 tests (including for invalid packages). But Is it possible to test for this 'no releases' label ? beacuse if I test it from any real package, soon or later that package may get official release. That time, it test will be failed. |
The way to accomplish that is using the |
Added 😄 |
Actual result:
"void"
Expected result:
"v1.0.0-alpha7"
There's the
v1.0.0-alpha7
tag: https://github.com/vaadin/vaadin-checkbox/releases/tag/v1.0.0-alpha7The text was updated successfully, but these errors were encountered: