Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bower] pre release badge added #1099

Merged
merged 4 commits into from
Sep 30, 2017
Merged

[Bower] pre release badge added #1099

merged 4 commits into from
Sep 30, 2017

Conversation

ritwickdey
Copy link
Contributor

Fixes #1098 (Pre-release badge added)

image

@ritwickdey ritwickdey mentioned this pull request Sep 26, 2017
Closed
@paulmelnikow
Copy link
Member

Could you add tests for the new and old badges?

@paulmelnikow paulmelnikow added enhancement service-badge New or updated service badge labels Sep 28, 2017
@ritwickdey
Copy link
Contributor Author

Ok! I'll add tests 😄

@paulmelnikow paulmelnikow changed the title Bower pre release badge added [Bower] pre release badge added Sep 28, 2017
@ritwickdey
Copy link
Contributor Author

Hi, @paulmelnikow ... It is ready :)

paulmelnikow
paulmelnikow approved these changes Sep 30, 2017
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks!

@paulmelnikow paulmelnikow merged commit f6a2e2c into badges:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritwickdey @paulmelnikow