Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github commit merge status in branch #1616

Closed
paulmelnikow opened this issue Mar 27, 2018 · 4 comments
Closed

Github commit merge status in branch #1616

paulmelnikow opened this issue Mar 27, 2018 · 4 comments
Assignees
Labels
service-badge New or updated service badge

Comments

@paulmelnikow
Copy link
Member

With an eye to reusability, here's a design for a new badge. This came up for our own use at #1605 (comment), though a lot of folks use branches for their deploy pipelines, so I feel like it could be handy beyond Shields.

https://img.shields.io/github/commit-status/gh-pages/ed419b0a77d89094e11466797dfae68d92a2fab9


https://img.shields.io/github/commit-status/gh-pages/ed419b0a77d89094e11466797dfae68d92a2fab9?label=deploy%20status


A future enhancement could allow overriding the message. Though that suggestion has come up before on other badges, and it might be a good problem to solve in a more global way.

@platan
Copy link
Member

platan commented Mar 31, 2018

This badge format would be useful when you have commit id. It's not a problem for a bot or when you know where to find id ;-) I was thinking about a simpler API, where we know branch name and PR id. It would take one extra API call to get commit id from PR.
But since we are going to automatically put a badge with deploy info in PR you proposal would do the job!

@paulmelnikow
Copy link
Member Author

Love the idea of showing the merge status of a PR! Perhaps I wrongly inferred it would be difficult to get the commit ID from an API call. Maybe then, the default label should be merge status.

@platan
Copy link
Member

platan commented May 27, 2018

I'm working on this badge (#1605 (comment)).

@platan platan self-assigned this May 29, 2018
@platan
Copy link
Member

platan commented May 31, 2018

Implemented in #1709

@platan platan closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

No branches or pull requests

2 participants