Deployment status in PR

[platan]

The idea started in #1605 (comment). We want "to post a comment at the end of a PR thread, which indicates whether it's been deployed yet".

There are two things we need:

• Badge with Github commit merge status in branch (Github commit merge status in branch #1616)
• a probot app for creating a comment in closed PR

[platan]

I think we have all required building blocks. We need to put them together.

• Badge with Github commit merge status in branch (Github commit merge status in branch #1616) is merged to master [github] Commit merge status badge #1709. We have to wait for a deployment. Meanwhile, we can use a temporary instance deployed at Now by me
  https://shields-deployment.now.sh/github/commit-status/badges/shields/gh-pages/9d90bd1f9549b3c8b59ad8338a8acd92e1e36f3c.svg?label=deploy%20status (9d90bd1)
  
  https://shields-deployment.now.sh/github/commit-status/badges/shields/gh-pages/fe4ac0bf1cbd0dbe04bf2cc439a2eee51f4c3907.svg?label=deploy%20status (fe4ac0b)
  
• A https://github.com/bkeepers/workflow configuration. I've deployed an instance of the workflow app https://github.com/apps/shields-deployment and used it in an example repo https://github.com/platan/shields-deployment-status-example, configuration https://github.com/platan/shields-deployment-status-example/blob/master/.github/probot.js, PR examples Update hello.txt platan/shields-deployment-status-example#4, Update hello.txt platan/shields-deployment-status-example#6. This example repo has branches similar to these in the shields repo (master + gh-pages).

What's next?

• We need a workflow app. We can use https://github.com/apps/shields-deployment (name, description, log can be changed). This instance is deployed by me at Now and is available or everyone. Alternatively we can create a new app (https://probot.github.io/docs/deployment/) at https://github.com/badges/shields or https://github.com/shields-ci
• We need someone who can install workflow app at https://github.com/badges/shields. Who can do it?
• We need a workflow configuration. I can create a PR with https://github.com/platan/shields-deployment-status-example/blob/master/.github/probot.js as a first version.

[chris48s]

Great work on this:

We need someone who can install workflow app at https://github.com/badges/shields. Who can do it?

If I click 'install' on https://github.com/apps/shields-deployment/ I seem to have permission to add the app to this repo with 'Read and write access to pull requests'. You should be able to do it as well - we have the same repo permissions.

If we add https://github.com/apps/shields-deployment and wanted to move it later, does it become problematic to move? Presumably we revoke one app and add another? If that's the case, I reckon submit a PR to add https://github.com/platan/shields-deployment-status-example/blob/master/.github/probot.js and we add https://github.com/apps/shields-deployment . If it there is a reason to move it later, we can do..

[platan]

I haven't check if I can install this app in Shields ;-) Thanks.
After installing this app we can change it's description/logo and even a name. New name is immediately visible in all comments. And we can always uninstall this app. I'll create a PR with a workflow configuration.

[platan]

#1724 is merged and we are ready to go. Would you like me to install https://github.com/apps/shields-deployment in shields (or one of you can do it if you want 😄)?

[chris48s]

I pressed the buttons :D

[paulmelnikow]

Awesome work on this! It's really exciting to see 😄

[chris48s]

@platan - is the final remaining job on this to switch shields-deployment.now.sh to shields.io after the next deploy gets done?

[platan]

@chris48s Additionally I would like to turn off "shields-deployment.now.sh". Therefore we should update all badges linking to the old domain: https://github.com/badges/shields/search?q=%22This+badge+displays+deployment+status%3A%22&type=Issues (switch to "shields.io").

[chris48s]

cool. Lets leave this issue open until that last bit of work is finished then

[RedSparr0w]

Looks like its live on shields now:

https://img.shields.io/github/commit-status/badges/shields/gh-pages/9d90bd1f9549b3c8b59ad8338a8acd92e1e36f3c.svg?label=deploy%20status

[platan]

All badges in comments created by bot (https://github.com/badges/shields/search?q=%22This+badge+displays+deployment+status%3A%22&type=Issues) are served from img.shields.io.