Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named logo link not working #1787

Closed
Richienb opened this issue Jul 17, 2018 · 10 comments · Fixed by #1794
Closed

Named logo link not working #1787

Richienb opened this issue Jul 17, 2018 · 10 comments · Fixed by #1794
Labels
bug Bugs in badges and the frontend frontend The Docusaurus app serving the docs site operations Hosting, monitoring, and reliability for the production badge servers

Comments

@Richienb
Copy link

Richienb commented Jul 17, 2018

The named logos link recreated here from the shields.io website directs to a 404 error.

@paulmelnikow paulmelnikow added operations Hosting, monitoring, and reliability for the production badge servers frontend The Docusaurus app serving the docs site bug Bugs in badges and the frontend labels Jul 17, 2018
@paulmelnikow
Copy link
Member

I wonder if there's an easy way to incorporate a directory listing into the front-end build.

@chris48s
Copy link
Member

This is currently a 404 because gh-pages has these additional commits at the tip which replace the source with the build output. We've just added the features in #1708 with the assumption that we can ff-merge commits from the master branch onto gh-pages. It might be nicer to present it as a dir listing as a separate issue, but it seems this break is a symptom of something we should change to support another feature anyway?

@paulmelnikow
Copy link
Member

If the deploy commits were built on an empty branch, I think we'd have a problem with #1708, but since the deploy commits are added at the tip (as before) that feature should keep working. Does that make sense?

@Richienb
Copy link
Author

Richienb commented Jul 17, 2018

... no. A concept map might help explain.

@chris48s
Copy link
Member

Yeah, sorry. Having read through #1774 properly I see what's going on now :)
Given that we should find some other way to expose these logos in the context of those changes to the deploy script.

@Richienb
Copy link
Author

Richienb commented Jul 19, 2018

I see. Just wondering when a fix will be rolled out.

  • Find out what's wrong
  • Use a temporary solution
  • Fix the problem

@chris48s
Copy link
Member

In the meantime, if you're looking for a list of the currently available named logos:

https://github.com/badges/shields/tree/57a1bf2f082be3c0bcef4250f6a5e783a02fc9cf/logo

@Richienb
Copy link
Author

Ok. Maybe consider changing the link to go to that specific commit

@paulmelnikow
Copy link
Member

Hey @Richienb, the fix is in progress. You can see what I've done in the review app:
https://shields-staging-pr-1794.herokuapp.com/

@Richienb
Copy link
Author

ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend frontend The Docusaurus app serving the docs site operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants