Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List the named logos in the frontend #1794

Merged
merged 3 commits into from
Jul 23, 2018
Merged

List the named logos in the frontend #1794

merged 3 commits into from
Jul 23, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Jul 22, 2018

This probably could be accomplished using a webpack config, however this approach is consistent with the way we handle badge examples and I like that it's very obvious what's happening.

I like @chris48s's idea of putting these on their own page, though we should resolve #1762 first. This seems like a good incremental improvement.

Fix #1787

screen shot 2018-07-22 at 5 28 30 pm

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-1794 July 22, 2018 22:26 Inactive
@paulmelnikow paulmelnikow requested a review from chris48s July 22, 2018 22:30
@paulmelnikow paulmelnikow added frontend The Docusaurus app serving the docs site bug Bugs in badges and the frontend labels Jul 22, 2018
@chris48s
Copy link
Member

Good call. I suspect #1762 may drag on for a bit, so this is good for for an interim solution.

One small thing is that the long list does push the content out very wide in a fullscreen window:

before:

screenshot at 2018-07-23 19 50 39

after:

screenshot at 2018-07-23 19 48 33

Do you think its worth putting this in a <div> with a max-width or something to keep it a bit more centred?

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-1794 July 23, 2018 19:34 Inactive
@shields-ci
Copy link

shields-ci commented Jul 23, 2018

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

⚠️

This PR added helper modules in lib/ but not accompanying tests. Generally helper modules should have their own tests.

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

@paulmelnikow
Copy link
Member Author

paulmelnikow commented Jul 23, 2018

Good call. I've updated in d7065ee and it'll be deployed here in a moment: https://shields-staging-pr-1794.herokuapp.com/

screen shot 2018-07-23 at 2 38 56 pm

@paulmelnikow paulmelnikow merged commit 5a62ed5 into master Jul 23, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

@paulmelnikow
Copy link
Member Author

Thanks!

@paulmelnikow paulmelnikow deleted the list-named-logos branch July 23, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend frontend The Docusaurus app serving the docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named logo link not working
3 participants