Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] Commit merge status badge #1709

Merged
merged 11 commits into from
May 30, 2018
Merged

[github] Commit merge status badge #1709

merged 11 commits into from
May 30, 2018

Conversation

platan
Copy link
Member

@platan platan commented May 28, 2018

Implements #1616 (comment). Probot app has access to merge commit sha, so we don't need more useful API (described here #1616 (comment)).
Service tests describes all cases I was able to come up with. Feel free to suggest other cases.

@platan platan changed the title Commit merge status badge [github] Commit merge status badge May 28, 2018
@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @platan!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on this 👍

Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Nice work!
👍

@platan
Copy link
Member Author

platan commented May 30, 2018

@chris48s @RedSparr0w Thank you for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants