Clean up some alerts detected by LGTM [pypi] #2010
Conversation
paulmelnikow
changed the title
Generated by 🚫 dangerJS |
|
Which Edit: And in #1205 it's still |
|
It's this one: https://github.com/apps/wip Yea, I've noticed it sometimes shows the wrong status. |
| @@ -8,7 +8,7 @@ const isPsycopg2Version = Joi.string().regex(/^v([0-9][.]?)+$/) | |||
|
|
|||
| // These regexes are the same, but declared separately for clarity. | |||
| const isPipeSeparatedPythonVersions = Joi.string().regex( | |||
| /^([0-9]+.[0-9]+(?: \| )?)+$/ | |||
| /^([0-9]+\.[0-9]+(?: \| )?)+$/ | |||
There was a problem hiding this comment.
It's a really helpful service!
|
@samlanning I'm curious to see if this change fixed the alerts. Is there a way I can trigger https://lgtm.com/projects/g/badges/shields/ to update using the latest build? |
|
@paulmelnikow I've given LGTM a poke to fetch and produce results for the latest version of your code, it should appear soon hopefully (it's usually once every 24 hours). Of course if you enable pull request integration, you'll be able to see how a PR would affect alerts immediately (before merging even) 😉 |
|
Looks like I got 3/4 right! |
|
@paulmelnikow in fairness, the message for the one you didn't fix did change, it's still triggered by the same query, but it's pointing out something different now :) |
https://lgtm.com/projects/g/badges/shields/alerts/?mode=list
To help us keep up to date on this, We could consider adding the readme badge and/or the GitHub integration.