Add LGTM badges to README #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
I'm game to turn on the integration and I got a 👍 in Discord from @PyvesB. One thought on the badges: I'm glad our code quality is A+ from LGTM's perspective, though I'm not sure I'm comfortable claiming or advertising that… so maybe we just include the alerts badge? |
|
I agree with @paulmelnikow, maybe having just the alerts badge on the Readme makes more sense for now. |
paulmelnikow
approved these changes
Sep 1, 2018
|
The logo is really fun, love seeing it on the Readme! |
|
Awesome, thanks everyone! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that you're down to only 2 alerts following #2010 (and as briefly discussed there), and have an
+Agrade, time to add the badges to the README?I'm not sure if this is the right location given that you don't have any other code quality related badges in the README.
And to help prevent the alert count going up any further, how about enabling the ci integration? :)
cc @paulmelnikow