-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerhub automated build integration #866 #888
Conversation
Is this duplicate of #856 |
Thanks for this PR. It does look like it overlaps with #856. I like your the way this handles the 404 / not found case. Could you add that to your branch for #856 @eddiewebb? The tag build feature would be a great addition, but unfortunately we can't have a badge that is "unbounded" in time or number of requests. To support the tag feature, we'd need them to add an API that allows accessing this information more directly. |
…ted url in try.html
@paulmelnikow added to #856, but checking for 404 which works for both invalid user and invalid repo (some reason docker hub returns valid JSON with invalid repo, but a html page for invalid user. |
Since this will need to be reworked, and we're tracking that in #935, I'll close this. |
…ted url in try.html
As stated in issue #866 I want to be able to have a badge which shows the dockerhub build status.