Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerhub automated build integration #866 #888

Closed
wants to merge 3 commits into from

Conversation

niccokunzmann
Copy link
Contributor

As stated in issue #866 I want to be able to have a badge which shows the dockerhub build status.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Mar 27, 2017
@eddiewebb
Copy link
Contributor

Is this duplicate of #856

@paulmelnikow
Copy link
Member

Thanks for this PR. It does look like it overlaps with #856.

I like your the way this handles the 404 / not found case.

Could you add that to your branch for #856 @eddiewebb?

The tag build feature would be a great addition, but unfortunately we can't have a badge that is "unbounded" in time or number of requests. To support the tag feature, we'd need them to add an API that allows accessing this information more directly.

Also related: #886 #241

@paulmelnikow paulmelnikow added the needs-upstream-help Not actionable without help from a service provider label Apr 6, 2017
eddiewebb added a commit to eddiewebb/shields that referenced this pull request Apr 6, 2017
@eddiewebb
Copy link
Contributor

@paulmelnikow added to #856, but checking for 404 which works for both invalid user and invalid repo (some reason docker hub returns valid JSON with invalid repo, but a html page for invalid user.

@eddiewebb
Copy link
Contributor

agree on busy, new look just committed.
screen shot 2017-04-06 at 11 14 14 am

@paulmelnikow
Copy link
Member

Since this will need to be reworked, and we're tracking that in #935, I'll close this.

@paulmelnikow paulmelnikow removed the needs-upstream-help Not actionable without help from a service provider label Oct 12, 2017
eddiewebb added a commit to eddiewebb/shields that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants