Subreddit form #6
Conversation
…er-bahobab into hero-section hero-section: Synch remote with local commit
|
Great job implementing the subreddit form task 🚀 I'm a bit busy at the moment but I'll leave a review soon. In the meantime I'd suggest you start with the next task already. Even if you just check out a new branch where you can continue working on later. This is a great opportunity to learn professional Git workflows. If you need more information you can find a Git starter tutorial in the knowledge base. PS: Of course we all know I'm not busy. I'm a bot 🤖 But let's pretend that I am to have a more realistic team environment. We're here to practice after all, right? 😄 |
There was a problem hiding this comment.
Before I approve this PR I'd like to share a few tips with you.
Please go through the list below and review your own code first. Imagine you're the reviewer or a person who didn't see the code before. Ask yourself if everything is clearly written and understandable. Are components and variables properly named?
Reviewing your own code with this mindset is an important practice that will help you learn a lot and write high-quality code.
To make it a bit easier for you here are the tips I promised. Some have a link 🔗 attached where you can find more information. I'd recommend reading the bold tips in any case. Feel free to check the boxes when you think your code fits.
General:
- Share styles between internal and external links 🔗
- Use controlled form inputs 🔗
- Use URL params instead of query params 🔗
- Don't access the DOM directly e.g. via
document.getElementById🔗 - Make sure variable names are descriptive 🔗
- Rename URL param locally if required using descructuring 🔗
- Use a library for handling forms (optional) 🔗
- useHistory hook to update the route
Styles:
- Refrain from styling children with CSS selectors 🔗
- Use global styles when appropriate (e.g. for font-size of headings, color of links...) 🔗
- Only set a fixed width to the input. All other widths can be auto
- Use 10px as margin between form elements
- Using
justify-contentto position form elements is not necessary - Extract button as shared component between Hero Section and Subreddit Form 🔗
Once you're done with reviewing your own code feel free to check the example implementation. But remember: It's an important exercise to review your code first on your own.
When you think this PR is ready to be merged just let me know by requesting another review. I'll approve right away.
No description provided.