Managed Pool: BPT management fees #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/pool-weighted/contracts/smart/ManagedPool.sol
nventuro
reviewed
Mar 29, 2022
nventuro
reviewed
Apr 5, 2022
nventuro
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Looks great! Let's get this merged so we can unblock all other PRs, given the massive size of this one.
We should later consider how we'll deal with join/exit swap fees, and evaluate improving the tests to have at least one scenario where we don't depend on a bunch of libraries to compute a result.
TomAFrench
added a commit
that referenced
this pull request
Apr 7, 2022
* master: (39 commits) Authorizer: Migration script (#1173) Managed Pool: BPT management fees (#1163) Improve token checkpointing logic (#1217) Prevent late lockers from having to claim many weeks of zero-value distributions (#1218) fix: make sure to use EVM time when calculating startTime (#1221) Add custom implementation of FeeDistributor contract (#1191) Authorizer: Improve grant/revoke delays granularity (#1197) Linear Pool: ERC4626 Finalized (#1177) Weighted pool: use correct compare operators (#1209) Re-do Polygon BalancerHelpers deployment Update deployments readme chore: deploy SmartWalletChecker to kovan (#1208) Add SmartWalletChecker (#1207) Update readme.md (#1206) veBAL deployment (#1205) Misc veBAL changes (#1204) chore: organise contracts in liquidity-mining package (#1203) Fix compile error Deploy Batch Relayer V2 to Polygon (#1182) Fix reading historical balances/total supply by timestamp (#1201) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends BPT protocol fee payment to ManagedPools: both protocol fees and management fees will be paid in BPT. Since the weights are not constant, this needs to be done on each swap, instead of joins/exits.