Prevent late lockers from having to claim many weeks of zero-value distributions #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
nventuro
reviewed
Apr 5, 2022
pkg/liquidity-mining/contracts/fee-distribution/FeeDistributor.sol
Outdated
Show resolved
Hide resolved
nventuro
approved these changes
Apr 6, 2022
TomAFrench
added a commit
that referenced
this pull request
Apr 7, 2022
* master: (39 commits) Authorizer: Migration script (#1173) Managed Pool: BPT management fees (#1163) Improve token checkpointing logic (#1217) Prevent late lockers from having to claim many weeks of zero-value distributions (#1218) fix: make sure to use EVM time when calculating startTime (#1221) Add custom implementation of FeeDistributor contract (#1191) Authorizer: Improve grant/revoke delays granularity (#1197) Linear Pool: ERC4626 Finalized (#1177) Weighted pool: use correct compare operators (#1209) Re-do Polygon BalancerHelpers deployment Update deployments readme chore: deploy SmartWalletChecker to kovan (#1208) Add SmartWalletChecker (#1207) Update readme.md (#1206) veBAL deployment (#1205) Misc veBAL changes (#1204) chore: organise contracts in liquidity-mining package (#1203) Fix compile error Deploy Batch Relayer V2 to Polygon (#1182) Fix reading historical balances/total supply by timestamp (#1201) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a concept of a
tokenStartTimeso that the contract knows from when users should attempt to claim a particular token if they haven't interacted with it before. This means that if we add a new token to be distributed then people don't have to make zero-value claims all the way from_startTimein order to sync the contract up to the current week.However the issue is we need the same concept for users (
userStartTime), otherwise if someone were to lock veBAL in 2 years time and want to claim BAL tokens then they would have to go through all previous BAL distributions whilst we know that they won't receive any fees from before their first lock.We then save the timestamp of the first week which the user would be eligible for a distribution and when first claiming a token we can fast forward to this week.