Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BaseMinimalSwapInfoPool #1758

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

TomAFrench
Copy link
Contributor

@TomAFrench TomAFrench commented Sep 14, 2022

splosh

And then there were two.

@TomAFrench TomAFrench force-pushed the remove_base_minimal_swap_pool branch from 28fe5d1 to 4a74ea7 Compare September 14, 2022 10:48
@TomAFrench TomAFrench requested a review from nventuro September 14, 2022 11:21
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Away it goes! Albeit to the wrong place 😂

@TomAFrench
Copy link
Contributor Author

Albeit to the wrong place joy

It'll need to get _poolState at some point so needs to know something of ManagedPool so I'm trying to bring it closer to that. We can be smart later.

@TomAFrench TomAFrench merged commit 3d1e814 into master Sep 14, 2022
@TomAFrench TomAFrench deleted the remove_base_minimal_swap_pool branch September 14, 2022 14:32
TomAFrench added a commit that referenced this pull request Sep 14, 2022
* master:
  Flatten `_isOnlyOwnerAction` (#1757)
  Push weighted join and exit types into a library (#1759)
  Removing unnecessary debug log from VaultActions test. (#1764)
  Using the same storage slot for read-only and temporary chained references. (#1763)
  Adding benchmark for relayer multicall (#1752)
  refactor: remove BaseMinimalSwapInfoPool (#1758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants