Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch Relayer V4] Using same storage slot for read-only and chained refs #1763

Merged
merged 1 commit into from
Sep 14, 2022
Merged

[Batch Relayer V4] Using same storage slot for read-only and chained refs #1763

merged 1 commit into from
Sep 14, 2022

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Sep 14, 2022

Closes #1762.

@jubeira jubeira requested a review from nventuro September 14, 2022 14:21
nventuro
nventuro approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johngrantuk this is the fix I mentioned earlier

@nventuro nventuro merged commit 6461702 into master Sep 14, 2022
@nventuro nventuro deleted the batch-relayer-ref-reuse branch September 14, 2022 14:40
@johngrantuk
Copy link
Member

@johngrantuk this is the fix I mentioned earlier

Thanks. Please let me know when you get a chance to redeploy on Goerli.

TomAFrench added a commit that referenced this pull request Sep 14, 2022
@TomAFrench
Merge branch 'master' into managed-swap-fees
bd67cfc 
* master:
  Flatten `_isOnlyOwnerAction` (#1757)
  Push weighted join and exit types into a library (#1759)
  Removing unnecessary debug log from VaultActions test. (#1764)
  Using the same storage slot for read-only and temporary chained references. (#1763)
  Adding benchmark for relayer multicall (#1752)
  refactor: remove BaseMinimalSwapInfoPool (#1758)
@jubeira jubeira mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove prefix when calculating chained reference slot
3 participants
@jubeira @johngrantuk @nventuro