Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deployments] Batch relayer V4 preparation. #1706

Merged
merged 10 commits into from
Sep 16, 2022

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Sep 6, 2022

  • Binaries, scripts and fork test (same as in V3).
  • Deprecating V3.
  • Updating README.

Juan Ignacio Ubeira added 2 commits September 6, 2022 14:44
- Binaries, scripts and fork test.
- Deprecating V3.
- Updating README.
@jubeira jubeira requested a review from nventuro September 6, 2022 18:28
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as do-not-merge since we don't yet have the final build info.

Can you do a goerli deployment of the current version however, so that the SDK team can test it?

pkg/deployments/tasks/20220906-batch-relayer-v4/readme.md Outdated Show resolved Hide resolved
@nventuro nventuro added the on hold Something is blocking this PR from being merged label Sep 7, 2022
@jubeira
Copy link
Contributor Author

jubeira commented Sep 8, 2022

Done: 34e5a7e

Juan Ignacio Ubeira added 2 commits September 14, 2022 14:09
- No return values for gauge actions.
- Chained reference slot fix (same for temp / read-only).
@jubeira
Copy link
Contributor Author

jubeira commented Sep 14, 2022

@johngrantuk the new deployment for the batch relayer in Goerli is ready; you can see more info here 2cda6a7.

This includes the changes in #1763 and #1765.
/cc @nventuro

@nventuro nventuro requested a review from TomAFrench September 16, 2022 18:19
@nventuro nventuro added this to the Batch Relayer v4 milestone Sep 16, 2022
@nventuro nventuro removed the on hold Something is blocking this PR from being merged label Sep 16, 2022
@TomAFrench
Copy link
Contributor

When building 2d310c3 I get the same build-info as committed

@nventuro
Copy link
Contributor

We're looking into an issue that seems to cause for the build info file to not be identical on every run - the file id is different, and some fields are in different order. But the actual contents of the source code, bytecode, etc., are all the same.

@nventuro nventuro merged commit a349d2b into master Sep 16, 2022
@nventuro nventuro deleted the deployment/batch-relayer-v4 branch September 16, 2022 21:13
TomAFrench added a commit that referenced this pull request Sep 19, 2022
* master:
  Upgrade ignore-warnings (#1789)
  Expose getter for expected compression error on ValueCompression.sol (#1793)
  Remove `_getTotalTokens` internal getter (#1794)
  Remove unused imports (#1795)
  Make base pool better (#1790)
  Update readme.md
  Deploy relayer v4 (#1791)
  [Deployments] Batch relayer V4 preparation. (#1706)
  refactor: remove BaseWeightedPool (#1788)
  Move ManagedPool swap, join, exit logic to ManagedPoolAMMLogic (#1787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants