Make base pool better #1790
Merged
Make base pool better #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No calls to this are made with user specified tokens so we can be sure it is a valid token
nventuro
approved these changes
Sep 19, 2022
Comment on lines
245
to
250
| poolId, | ||
| sender, | ||
| recipient, | ||
| balances, | ||
| lastChangeBlock, | ||
| inRecoveryMode() ? 0 : protocolSwapFeePercentage, // Protocol fees are disabled while in recovery mode |
There was a problem hiding this comment.
We can change the internal handler to not receive data we know we don't care about, such as the fee percentage, recipient, or last change block
EndymionJkb
reviewed
Sep 19, 2022
TomAFrench
added a commit
that referenced
this pull request
Sep 19, 2022
* master: Upgrade ignore-warnings (#1789) Expose getter for expected compression error on ValueCompression.sol (#1793) Remove `_getTotalTokens` internal getter (#1794) Remove unused imports (#1795) Make base pool better (#1790) Update readme.md Deploy relayer v4 (#1791) [Deployments] Batch relayer V4 preparation. (#1706) refactor: remove BaseWeightedPool (#1788) Move ManagedPool swap, join, exit logic to ManagedPoolAMMLogic (#1787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.