Remove _getTotalTokens internal getter
#1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Remove unused imports (#1795)
nventuro
approved these changes
Sep 19, 2022
| @@ -332,8 +329,6 @@ abstract contract BasePool is | |||
| uint256 protocolSwapFeePercentage, | |||
| bytes memory userData | |||
| ) external override returns (uint256 bptOut, uint256[] memory amountsIn) { | |||
| InputHelpers.ensureInputLengthMatch(balances.length, _getTotalTokens()); | |||
There was a problem hiding this comment.
This is safe to do because we also don't check the length in eg. onJoinPool. _onJoin and _onExit must implement this check.
There was a problem hiding this comment.
However we have must stronger trust in the caller in those cases. If the Vault has fallen out of sync with the Pool then the Pool has acted improperly. Users can provide arbitrary data however.
TomAFrench
added a commit
that referenced
this pull request
Sep 19, 2022
* master: Upgrade ignore-warnings (#1789) Expose getter for expected compression error on ValueCompression.sol (#1793) Remove `_getTotalTokens` internal getter (#1794) Remove unused imports (#1795) Make base pool better (#1790) Update readme.md Deploy relayer v4 (#1791) [Deployments] Batch relayer V4 preparation. (#1706) refactor: remove BaseWeightedPool (#1788) Move ManagedPool swap, join, exit logic to ManagedPoolAMMLogic (#1787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually do length checking of the
balancesarray when upscaling so this check is unnecessary.