Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should error when the combination of device-type, device and image parameter resolve to a conflicting DT #2537

Closed
jellyfish-bot opened this issue Oct 13, 2022 · 0 comments · Fixed by #2556
Closed

Should error when the combination of device-type, device and image parameter resolve to a conflicting DT #2537

jellyfish-bot opened this issue Oct 13, 2022 · 0 comments · Fixed by #2556

Comments

@jellyfish-bot
Copy link

jellyfish-bot commented Oct 13, 2022 •
edited by thgreasi
Loading

[thgreasi] We should change the CLI to error when the combination of parameters is conflicting eg:

  • balena os configure: when passing --deviceType & --device that resolves to a different device type.
  • Anywhere we provide an image path as a parameter and a --deviceType param or a --device param and the DTs do not match w/ the image (eg: balena os configure).
  • balena config generate: when passing --deviceType & --device that resolves to a different device type.

See: https://jel.ly.fish/brainstorm-topic-discuss-ease-users-w-devices-showing-wrong-dt-fix-automatic-f8186de
thgreasi added a commit that referenced this issue Nov 8, 2022
@thgreasi
Error when the device type and image parameters do not match
3bb1577 
Resolves: #2537
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
@thgreasi thgreasi mentioned this issue Nov 8, 2022
Merged
thgreasi added a commit that referenced this issue Nov 8, 2022
@thgreasi
Error when the device type and image parameters do not match
a2ea9f7 
Resolves: #2537
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
ab77 pushed a commit that referenced this issue Nov 10, 2022
@thgreasi @ab77
Error when the device type and image parameters do not match
13edfe7 
Resolves: #2537
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
ab77 pushed a commit that referenced this issue Nov 10, 2022
@thgreasi @ab77
Error when the device type and image parameters do not match
4de369f 
Resolves: #2537
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
@ghost ghost closed this as completed in #2556 Nov 10, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error when the device type and image parameters do not match balena-io/balena-cli
1 participant
@jellyfish-bot