Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when the device type and image parameters do not match #2556

Merged
1 commit merged into from
Nov 10, 2022

Conversation

thgreasi
Copy link
Member

@thgreasi thgreasi commented Nov 8, 2022

Resolves: #2537
Change-type: patch
Signed-off-by: Thodoris Greasidis thodoris@balena.io

Resolves: #
Change-type: major|minor|patch
Depends-on:
See:


Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.

If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.

Thank you very much for your contribution!

@thgreasi thgreasi marked this pull request as ready for review November 8, 2022 08:43
@thgreasi thgreasi force-pushed the 2537-error-on-incompatible-resolved-device-types branch from 3bb1577 to a2ea9f7 Compare November 8, 2022 08:58
@thgreasi
Copy link
Member Author

thgreasi commented Nov 8, 2022

@balena-ci I self-certify!

@thgreasi
Copy link
Member Author

thgreasi commented Nov 8, 2022

@balena-ci restest

@thgreasi
Copy link
Member Author

thgreasi commented Nov 8, 2022

@balena-ci retest

Resolves: #2537
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
@ab77 ab77 force-pushed the 2537-error-on-incompatible-resolved-device-types branch from a2ea9f7 to 4de369f Compare November 10, 2022 17:37
@ghost ghost merged commit cf16957 into master Nov 10, 2022
@ghost ghost deleted the 2537-error-on-incompatible-resolved-device-types branch November 10, 2022 18:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should error when the combination of device-type, device and image parameter resolve to a conflicting DT
1 participant