Enable the crt-static target feature for all targets #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbarros
force-pushed
the
lmb/static-builds
branch
4 times, most recently
from
ab2c369
to
f5c7797
Compare
We were relying on the fact that our current targets link the C runtime statically. However, this may be different for other targets and could even change in the future (e.g., see rust-lang/compiler-team#422). With this commit we adopt the current recommendation, which is enabling the crt-static target feature when building. See https://doc.rust-lang.org/reference/linkage.html#static-and-dynamic-c-runtimes for details. Given the current defaults for Rust targets, this change should be a no-op, but this shall make us safer and more resilient to Rust changes in the long run. Signed-off-by: Leandro Motta Barros <leandro@balena.io> Change-type: patch
lmbarros
force-pushed
the
lmb/static-builds
branch
from
f5c7797
to
072addb
Compare
lmbarros
changed the title
rahul-thakoor
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
looks like the flag is being passed correctly
+ /usr/bin/docker run --userns host -e 'RUSTFLAGS=-C target-feature=+crt-static' -e 'PKG_CONFIG_ALLOW_CROSS=1' -e 'XARGO_HOME=/xargo' -e 'CARGO_HOME=/cargo' -e 'CARGO_TARGET_DIR=/target' -e 'CROSS_RUNNER=' -e CARGO_REGISTRY -e CARGO_TERM_COLOR -e CARGO_INCREMENTAL -e 'USER=runner' --rm --user 1001:127 -v /home/runner/.xargo:/xargo:z -v /home/runner/.cargo:/cargo:z -v /cargo/bin -v /home/runner/work/takeover/takeover:/project:z -v /home/runner/.rustup/toolchains/1.76-x86_64-unknown-linux-gnu:/rust:z,ro -v /home/runner/work/takeover/takeover/target:/target:z -w /project ghcr.io/cross-rs/aarch64-unknown-linux-musl:0.2.5 sh -c 'PATH=$PATH:/rust/bin cargo -v build --release --target aarch64-unknown-linux-musl'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on the fact that our current targets link the C runtime
statically. However, this may be different for other targets and could
even change in the future (e.g., see
rust-lang/compiler-team#422).
With this commit we adopt the current recommendation, which is enabling
the crt-static target feature when building. See
https://doc.rust-lang.org/reference/linkage.html#static-and-dynamic-c-runtimes
for details.
Given the current defaults for Rust targets, this change should be a
no-op, but this shall make us safer and more resilient to Rust changes
in the long run.