Build and Publish wifi-connect-ui #566
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-thakoor
force-pushed
the
rahul/fix-missing-ui-directory
branch
4 times, most recently
from
2384517 to
a6bd318
Compare
klutchell
reviewed
May 23, 2024
klutchell
reviewed
May 23, 2024
rahul-thakoor
force-pushed
the
rahul/fix-missing-ui-directory
branch
9 times, most recently
from
e2636cf to
fad5560
Compare
- use custom publish action for building and publishing the ui Change-type: patch Signed-off-by: Rahul Thakoor <rahul@balena.io>
- react-scripts v3.x fails with `Error: error:0308010c:digital envelope routines::unsupported [Node Error Solved]` on Node v20.x Change-type: patch Signed-off-by: Rahul Thakoor <rahul@balena.io>
Change-type: patch
Change-type: patch
Change-type: patch
rahul-thakoor
force-pushed
the
rahul/fix-missing-ui-directory
branch
3 times, most recently
from
da3cb98 to
bbaada9
Compare
Change-type: patch Signed-off-by: Rahul Thakoor <rahul@balena.io>
Change-type: patch Signed-off-by: Rahul Thakoor <rahul@balena.io>
rahul-thakoor
force-pushed
the
rahul/fix-missing-ui-directory
branch
from
bbaada9 to
c6c8f9f
Compare
Change-type: patch Signed-off-by: Rahul Thakoor <rahul@balena.io>
|
The GHA/Flowzone changes look good to me! |
|
@rahul-thakoor @klutchell any idea when this will be merged? |
shawaj
added a commit
to shawaj/balena-ads-b
that referenced
this pull request
Aug 22, 2024
Temporary fix for ketilmo#142 - pull in required changes from balena-os/wifi-connect#566 - increase timeout from 120 seconds to 180 seconds Closes: ketilmo#142
ketilmo
pushed a commit
to ketilmo/balena-ads-b
that referenced
this pull request
Aug 26, 2024
* wifi-connect: temporary fix Temporary fix for #142 - pull in required changes from balena-os/wifi-connect#566 - increase timeout from 120 seconds to 180 seconds Closes: #142 * fix: dbus address error Fixes the error `D-Bus error: In D-Bus address, character '"' should have been escaped`
|
What's missing for this PR to get merged? |
You can just fork it and use it in your project if you want. That's what we did. |
|
seriously why is this not merged lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: error:0308010c:digital envelope routines::unsupported [Node Error Solved]Dockerfile.templateto download pre-builtwifi-connect-ui