Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and Publish wifi-connect-ui #566

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rahul-thakoor
Copy link
Contributor

@rahul-thakoor rahul-thakoor commented May 23, 2024

  • use custom publish action for building and publishing the ui
  • update react-scripts to v5.x to be compatible with NodeJS 20.x otherwise builds fail with Error: error:0308010c:digital envelope routines::unsupported [Node Error Solved]
  • Update Dockerfile.template to download pre-built wifi-connect-ui

@rahul-thakoor rahul-thakoor force-pushed the rahul/fix-missing-ui-directory branch 4 times, most recently from 2384517 to a6bd318 Compare May 23, 2024 17:53
@rahul-thakoor rahul-thakoor force-pushed the rahul/fix-missing-ui-directory branch 9 times, most recently from e2636cf to fad5560 Compare May 24, 2024 11:47
rahul-thakoor and others added 5 commits May 27, 2024 08:52
- use custom publish action for building and publishing the ui

Change-type: patch
Signed-off-by: Rahul Thakoor <rahul@balena.io>
- react-scripts v3.x fails with `Error: error:0308010c:digital envelope routines::unsupported [Node Error Solved]`
  on Node v20.x

Change-type: patch
Signed-off-by: Rahul Thakoor <rahul@balena.io>
Change-type: patch
@rahul-thakoor rahul-thakoor force-pushed the rahul/fix-missing-ui-directory branch 3 times, most recently from da3cb98 to bbaada9 Compare May 27, 2024 13:58
Change-type: patch
Signed-off-by: Rahul Thakoor <rahul@balena.io>
Change-type: patch
Signed-off-by: Rahul Thakoor <rahul@balena.io>
@rahul-thakoor rahul-thakoor force-pushed the rahul/fix-missing-ui-directory branch from bbaada9 to c6c8f9f Compare May 27, 2024 14:11
Change-type: patch
Signed-off-by: Rahul Thakoor <rahul@balena.io>
@rahul-thakoor rahul-thakoor marked this pull request as ready for review May 27, 2024 18:24
@rahul-thakoor rahul-thakoor marked this pull request as draft May 27, 2024 18:39
@klutchell
Copy link
Contributor

The GHA/Flowzone changes look good to me!

@shawaj
Copy link

shawaj commented Aug 22, 2024

@rahul-thakoor @klutchell any idea when this will be merged?

shawaj added a commit to shawaj/balena-ads-b that referenced this pull request Aug 22, 2024
Temporary fix for ketilmo#142
- pull in required changes from balena-os/wifi-connect#566
- increase timeout from 120 seconds to 180 seconds
shawaj added a commit to shawaj/balena-ads-b that referenced this pull request Aug 22, 2024
Temporary fix for ketilmo#142
- pull in required changes from balena-os/wifi-connect#566
- increase timeout from 120 seconds to 180 seconds

Closes: ketilmo#142
ketilmo pushed a commit to ketilmo/balena-ads-b that referenced this pull request Aug 26, 2024
* wifi-connect: temporary fix

Temporary fix for #142
- pull in required changes from balena-os/wifi-connect#566
- increase timeout from 120 seconds to 180 seconds

Closes: #142

* fix: dbus address error

Fixes the error `D-Bus error: In D-Bus address, character '"' should have been escaped`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants