wifi-connect: temporary fix #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just need to test this works as expected |
|
All tested and works perfectly on my local device. Just used it to configure wifi. |
Closed
Temporary fix for ketilmo#142 - pull in required changes from balena-os/wifi-connect#566 - increase timeout from 120 seconds to 180 seconds Closes: ketilmo#142
Fixes the error `D-Bus error: In D-Bus address, character '"' should have been escaped`
|
Added a fix for this, when trying to run directly from terminal...
|
|
Awesome @shawaj! Thank you for identifying and resolving this issue with this temporary fix. LGTM. |
|
Hopefully the fix gets merged upstream soon 🤞 |
|
Fingers crossed for that, @shawaj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #142
D-Bus error: In D-Bus address, character '"' should have been escapeddue to incorrect env variableCloses: #142