Add support for both Faraday 1.x and 2.x #133
Conversation
Changelog: https://github.com/lostisland/faraday/blob/main/UPGRADING.md#faraday-20 To support Faraday 2.x, the `faraday_middleware` library is no longer required for sending/receiving JSON bodies, and each individual adapter is shipped as a separate gem (e.g. faraday-patron). Since it's quite hard to update Faraday everywhere (because it is a dependency of many different gems), we should support both versions in Spyke to allow users to upgrade Faraday on their terms.
|
Hello @nickcampbell18! Thanks so much for kicking this off. 💪 Having tested out Spyke with Faraday 2.x locally, it seems like maybe there is quite a few other places that will need tweaking... 😓 I have a WIP branch at https://github.com/balvig/spyke/compare/jb/faraday-support that isn't working yet, will probably take a bit more time/effort as it looks like at least need to address:
|
|
I'm getting flashbacks of the Faraday 1.x upgrade 😭 If it helps, for the middleware namespace, I found it was simple to swap out the parent class, and the But yeah, multipart...fun 🎉 |
|
@nickcampbell18 after a bit of fiddling around, I think I have it working in #135. |
## What - Adds support for Faraday >= 2.0 - Preserves support for Faraday < 2.0 - Updates documentation to cover both versions - Adds Faraday versions to test matrix - Closes #133
Changelog: https://github.com/lostisland/faraday/blob/main/UPGRADING.md#faraday-20
To support Faraday 2.x, the
faraday_middlewarelibrary is no longer required for sending/receiving JSON bodies, and each individual adapter is shipped as a separate gem (e.g. faraday-patron).Since it's quite hard to update Faraday everywhere (because it is a dependency of many different gems), we should support both versions in Spyke to allow users to upgrade Faraday on their terms.