Add support for Faraday 2.x #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcampbell18
force-pushed
the
faraday-2x
branch
from
e4d153e to
3a7dde1
Compare
They changed the middleware namespace, so we need to support both for the time being.
nickcampbell18
force-pushed
the
faraday-2x
branch
from
3a7dde1 to
d07ad11
Compare
nickcampbell18
commented
Mar 29, 2022
| @@ -62,7 +65,7 @@ GEM | |||
| rake (13.0.3) | |||
| rexml (3.2.5) | |||
| ruby2_keywords (0.0.5) | |||
| spyke (6.0.0) | |||
| spyke (6.1.3) | |||
There was a problem hiding this comment.
Unfortunately spyke is holding us back on 1.x - see balvig/spyke#133 - but this will work when that is eventually updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They changed the middleware namespace, so we need to support both for the time being 🤮