Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename plotting function names #704

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

GStechschulte
Copy link
Collaborator

@GStechschulte GStechschulte commented Aug 16, 2023

This PR renames plot_cap to plot_predictions and plot_comparison to plot_comparisons.

  • The function name plot_predictions is more informative and is the same as marginaleffects.
  • The suffix "s" was added to plot_comparison to make it consistent (plural) with the other function names (slopes, predictions, etc.)

In doing so, I changed the syntax in any referencing file, tests, and in the documentation.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@GStechschulte GStechschulte changed the title rename plot_cap and plot_comparison to plot_predictions and plot_comp… rename plotting function names Aug 16, 2023
@tomicapretto tomicapretto merged commit 5dde496 into bambinos:main Aug 17, 2023
tomicapretto added a commit that referenced this pull request Aug 17, 2023
@GStechschulte GStechschulte deleted the rename-functions branch January 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants