Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plots submodule name to interpret #705

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

GStechschulte
Copy link
Collaborator

@GStechschulte GStechschulte commented Aug 16, 2023

This PR changes the plots submodule name to interpret as the functions in this sub package are not limited to plotting functions only. Additionally, this draft PR aims exposes the sub package functions in the main Bambi package to allow imports such as

import bambi as bmb

bmb.interpret.predictions()
# or
bmb.interpret.plot_predictions()

Any referencing files, documentation, and tests have been edited to reflect this change.

Note: this branch was a checkout of the branch for PR #704 (once PR 704 is merged, then this can be merged).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@GStechschulte GStechschulte marked this pull request as ready for review August 16, 2023 20:14
Co-authored-by: Osvaldo A Martin <aloctavodia@gmail.com>
@aloctavodia
Copy link
Collaborator

I think the errors come from this line

https://github.com/bambinos/bambi/blob/main/pyproject.toml#L61C20-L61C20

as that directory no longer exists

@GStechschulte
Copy link
Collaborator Author

I think the errors come from this line

https://github.com/bambinos/bambi/blob/main/pyproject.toml#L61C20-L61C20

as that directory no longer exists

Ahh yes, thanks for the hint 👍🏼

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #705 (b4d4720) into main (5dde496) will decrease coverage by 0.08%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   89.57%   89.50%   -0.08%     
==========================================
  Files          43       44       +1     
  Lines        3522     3526       +4     
==========================================
+ Hits         3155     3156       +1     
- Misses        367      370       +3     
Files Changed Coverage Δ
bambi/interpret/utils.py 86.76% <ø> (ø)
bambi/plots/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
bambi/__init__.py 76.47% <100.00%> (+1.47%) ⬆️
bambi/interpret/__init__.py 100.00% <100.00%> (ø)
bambi/interpret/create_data.py 100.00% <100.00%> (ø)
bambi/interpret/effects.py 89.24% <100.00%> (ø)
bambi/interpret/plot_types.py 73.39% <100.00%> (ø)
bambi/interpret/plotting.py 84.96% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto
Copy link
Collaborator

tomicapretto commented Aug 17, 2023

@GStechschulte if I merge this, there's no need to merge #704, right?

edit I merged and created conflicts 😅 , I will fix them

@GStechschulte
Copy link
Collaborator Author

GStechschulte commented Aug 17, 2023

@GStechschulte if I merge this, there's no need to merge #704, right?

edit I merged and created conflicts 😅 , I will fix them

Just let me know if I should do something. It is also my fault. I created excess work with PR #704 since it could have all been in one PR.

@tomicapretto
Copy link
Collaborator

@GStechschulte if I merge this, there's no need to merge #704, right?
edit I merged and created conflicts 😅 , I will fix them

Just let me know if I should do something. It is also my fault. I created excess work with PR #704 since it could have all been in one PR.

no worries! It's fixed now

@tomicapretto tomicapretto merged commit 00f415c into bambinos:main Aug 17, 2023
@GStechschulte GStechschulte deleted the change-submodule-name branch January 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants