-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change plots
submodule name to interpret
#705
Change plots
submodule name to interpret
#705
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Osvaldo A Martin <aloctavodia@gmail.com>
I think the errors come from this line https://github.com/bambinos/bambi/blob/main/pyproject.toml#L61C20-L61C20 as that directory no longer exists |
Ahh yes, thanks for the hint 👍🏼 |
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 89.57% 89.50% -0.08%
==========================================
Files 43 44 +1
Lines 3522 3526 +4
==========================================
+ Hits 3155 3156 +1
- Misses 367 370 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@GStechschulte if I merge this, there's no need to merge #704, right? edit I merged and created conflicts 😅 , I will fix them |
Just let me know if I should do something. It is also my fault. I created excess work with PR #704 since it could have all been in one PR. |
no worries! It's fixed now |
This PR changes the
plots
submodule name tointerpret
as the functions in this sub package are not limited to plotting functions only. Additionally, this draft PR aims exposes the sub package functions in the main Bambi package to allow imports such asAny referencing files, documentation, and tests have been edited to reflect this change.
Note: this branch was a checkout of the branch for PR #704 (once PR 704 is merged, then this can be merged).