Laravel 6.0 Support #203

dp88 · 2019-09-04T19:56:34Z

I've updated composer.json to include support for Laravel 6.0. The other change that needed addressing is that Laravel 6 removes the str_* and array_* helper functions in favor of accessing those methods via Illuminate\Support\Str and Illuminate\Support\Arr respectively.

edit: I've also confirmed that all tests still pass going back to Laravel 5.3.

BenSampo · 2019-09-05T07:50:13Z

Re broken tests on PHP 7.1, from the Laravel 6 upgrade notes:

"PHP 7.1 will no longer be actively maintained as of December 2019. Therefore, Laravel 6.0 requires PHP 7.2 or greater."

reececomo · 2019-09-27T05:20:34Z

What's the next step here?

If you want, we can signal to Travis to skip the PHP 7.1 step on Laravel 6.0 builds?

dp88 · 2019-10-02T19:09:14Z

Re broken tests on PHP 7.1, from the Laravel 6 upgrade notes:

"PHP 7.1 will no longer be actively maintained as of December 2019. Therefore, Laravel 6.0 requires PHP 7.2 or greater."

If you want, we can signal to Travis to skip the PHP 7.1 step on Laravel 6.0 builds?

I think it makes sense to drop the PHP 7.1 step from Travis altogether.

@baopham what's your preference? Are you available to review and merge this PR?

reececomo · 2019-10-03T02:35:50Z

Given that PHP 7.1 to 7.2 is such a minor upgrade, I think that makes sense @dp88.

You can still install a functioning Laravel 5.x version of baopham/laravel-dynamodb through the tagged versions.

Since PHP 7.1 will no longer be actively maintained after December of this year.

scrutinizer-notifier · 2019-10-03T13:04:25Z

The inspection completed: No new issues

reececomo · 2019-10-11T02:49:37Z

@baopham Any chance of a merge here?

You could create a laravel-5-* branch and have master be for the latest version of laravel? 😄

crynobone · 2019-10-11T03:05:07Z

Anyone maintaining a temporary fork with Laravel 6 support.

dp88 · 2019-10-11T13:12:43Z

I have a working Laravel 6 branch on my own fork, but I can't commit to maintaining it long term:
https://github.com/stechstudio/laravel-dynamodb/tree/dev-master

reececomo · 2019-10-14T02:31:44Z

@baopham still active or?

gilbertronaldo · 2019-11-05T04:26:12Z

@baopham hello?

lamungu · 2019-11-14T17:30:58Z

@baopham Would be great to know if this would also be available for Laravel 6.x onwards. The framework is already at 6.5 and this repo has yet to be updated

a-kova · 2019-12-10T13:01:38Z

@baopham Can you please update what's the status of this repo. Waiting for 6.* support also

reececomo · 2019-12-11T00:18:41Z

@baopham we’re at 6.7 already

JackPriceBurns · 2020-01-21T09:30:42Z

@reececomo @Kovalchuk91 @lamungu @gilbertronaldo @dp88 maybe it would be best if one of us forks the package and starts maintaining it, this repo doesn't appear to be active anymore and 6.x support is a must, Laravel 6 has been out for a while now.

I would be willing to help maintain or just maintain it myself and improve the package in a few places.

reececomo · 2020-01-21T10:34:26Z

@JackPriceBurns @Kovalchuk91 @lamungu @gilbertronaldo @dp88 I'm down for that.

Maybe /laravel-dynamo or /laradynamodb is available?

We should let @dp88 do it so he can get the delicious open source credit. Otherwise I've created us a new laravel team in the HubrioAU organisation if you're happy to put it there

reececomo · 2020-01-21T10:48:11Z

Have created a Laravel 6 fork in the meantime (and added everyone mentioned as project maintainers) to: https://github.com/hubrioAU/laravel-dynamodb

Otherwise if @dp88 wants to make it, I say we move to his.

crynobone · 2020-01-21T11:02:58Z

There https://github.com/rennokki/dynamodb

I also made a fork via https://github.com/laravie/eloquent-dynamodb but does require namespace rename

JackPriceBurns · 2020-01-21T14:53:11Z

I like the idea of having an organisation and us all work on it there, we now have 3 repos + the original + dp88's repo to work with, so we should come to a consensus as to which to use.

dp88 mentioned he can't commit to maintaining his repo long term, so maybe best would be reececomo's repo?

baopham · 2020-01-21T15:00:57Z

Hey, sorry all. I was completely away.

baopham · 2020-01-21T15:07:37Z

If anyone is interested in maintaining this repo, let me know #213!

baopham · 2020-01-21T15:15:10Z

Release with tag v5.0.0

BenSampo · 2020-01-21T15:16:44Z

Thanks @baopham 👍

dp88 · 2020-01-21T16:03:36Z

I'm afraid I don't have the bandwidth to maintain a fork at this time. Thanks for merging though, @baopham.

reececomo · 2020-01-22T06:20:27Z

All good, I'd say continue to work on this here 👍

Thanks for merging @baopham -- @JackPriceBurns @dp88 might be worth adding yourselves as maintainers

commit fe56587 Merge: 5f72c16 3833ac8 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Thu Feb 18 11:49:07 2021 +0000 Merge pull request baopham#234 from stancl/patch-1 Improve installation instructions commit 5f72c16 Merge: 2c7cba9 8827e04 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Thu Feb 18 11:46:46 2021 +0000 Merge pull request baopham#236 from xengulai/getClientDynamicConnectionName Allow connection name to be gathered dynamically commit 8827e04 Author: Jaysen Nuttall <j.nuttall@plansight.com> Date: Mon Feb 15 15:48:25 2021 -0700 Allow connection name to be gathered dynamically commit 3833ac8 Author: Samuel Štancl <samuel.stancl@gmail.com> Date: Fri Jan 8 20:03:30 2021 +0100 Improve installation instructions commit 2c7cba9 Merge: ae85c92 587ede8 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Wed Sep 30 11:45:19 2020 +0100 Merge pull request baopham#230 from baopham/hotfix/travis-fix Fix issues with travis ci commit 587ede8 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Wed Sep 30 11:38:37 2020 +0100 Fix issues with travis ci commit ae85c92 Merge: e5290d8 387a5e9 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Wed Sep 30 11:26:52 2020 +0100 Merge pull request baopham#225 from alfredkoncsag/patch-1 Update README.md commit e5290d8 Merge: 0d12b73 b9217ae Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Wed Sep 30 11:22:56 2020 +0100 Merge pull request baopham#226 from fd-automox/7.4-fix Fix an invalid array access and enable CI for PHP 7.4 commit 0d12b73 Merge: cab7a95 57510e2 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Wed Sep 30 09:29:46 2020 +0100 Merge pull request baopham#227 from aislandener/patch-1 Documentation of Where clause with error commit cab7a95 Merge: 3c85a7b aaf8068 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Wed Sep 30 09:23:19 2020 +0100 Merge pull request baopham#229 from madeITBelgium/patch-1 Add support for Laravel 8 commit aaf8068 Author: Made I.T <info@madeit.be> Date: Tue Sep 15 22:24:24 2020 +0200 Add support for Laravel 8 commit 57510e2 Author: Aislan Dener Souza Vicentini <aislandenersouzavicentini@gmail.com> Date: Tue Aug 11 09:26:07 2020 -0300 Documentation of Where clause with error In the Where AND and OR documentation part there was no comma between the second and third parameters commit b9217ae Author: Fred Dysart <fred.dysart@automox.com> Date: Sat Aug 8 11:56:13 2020 -0600 Be consistent with how the type is accessed commit c054ebb Author: Fred Dysart <fred.dysart@automox.com> Date: Sat Aug 8 11:41:00 2020 -0600 Fix an invalid array access and enable CI for PHP 7.4 commit 387a5e9 Author: alfredkoncsag <koncsagalfred@gmail.com> Date: Thu Aug 6 12:25:03 2020 +0200 Update README.md Fix query index commit 3c85a7b Author: Pele <peleodiase@yahoo.co.uk> Date: Mon Mar 23 04:46:28 2020 +0000 Add support for Laravel 7 (baopham#218) commit a656c26 Author: Tudor-Dan Ravoiu <tudor2004@yahoo.com> Date: Mon Mar 23 06:46:07 2020 +0200 Fix PHP ^7.4 Notice: Trying to access array offset on value of type null (baopham#217) It seems that under PHP ^7.4 this check is throwing an notice when trying to run a query without using primary/composite key as filter attributes (so when trying to run a DynamoDB scan). This fix checks if the key is set and uses null otherwise. commit b442ad5 Author: Gustave P <56343436+guspio@users.noreply.github.com> Date: Sat Feb 1 05:01:31 2020 +0100 Changed version system for Laravel 6 (baopham#216) commit bc58f54 Author: Jack Price-Burns <JackPriceBurns@outlook.com> Date: Tue Jan 21 15:12:40 2020 +0000 Update readme to fix issue with facades (baopham#214) commit 6f16f9d Author: David Palmer <dp88@users.noreply.github.com> Date: Tue Jan 21 10:00:47 2020 -0500 Laravel 6.0 Support (baopham#203) * Laravel 6.0 Support * Remove PHP 7.1 Step from Travis Since PHP 7.1 will no longer be actively maintained after December of this year. commit 77239f9 Author: footballencarta <footballencarta@users.noreply.github.com> Date: Fri Mar 22 15:04:47 2019 -0400 Updated to run with Laravel 5.8 and fix tests (baopham#194) commit d080e78 Merge: af4f908 c17c2f9 Author: Bao Pham <gbaopham@gmail.com> Date: Thu Mar 21 23:28:10 2019 +0800 Merge pull request baopham#193 from sahilsharma011/patch-1 Update docs for find and findMany functions commit c17c2f9 Author: Sahil Sharma <sahilsharma011@users.noreply.github.com> Date: Fri Mar 8 15:37:16 2019 +0530 Update docs for find and findMany functions I wanted to use batchGetItem method using this package, but I was not able to find any function in docs which provided this functionality. When I went into the code, I found that there was already a function using batchGetItem method, but it was not listed in the docs. So I wanted to update the docs to make it clear. commit af4f908 Merge: 45bd597 05c0275 Author: Bao Pham <gbaopham@gmail.com> Date: Mon Feb 25 22:38:57 2019 +0800 Merge pull request baopham#190 from sahilsharma011/removeIsNotEmpty Change isNotEmpty to isEmpty commit 05c0275 Author: Sahil Sharma <sahilsharma011@gmail.com> Date: Mon Feb 25 14:43:06 2019 +0530 Change isNotEmpty to isEmpty commit 45bd597 Merge: 71aa7b5 a470c15 Author: Bao Pham <gbaopham@gmail.com> Date: Fri Feb 22 14:23:38 2019 +0800 Merge pull request baopham#187 from thomasedwards/patch-1 Adds note to README about SerializesModels on Jobs commit a470c15 Author: Thomas Edwards <thomas.edwards@gmail.com> Date: Mon Feb 18 12:06:52 2019 +0000 Adds spaces to EOL for Markdown formatting commit 37436a9 Author: Thomas Edwards <thomas.edwards@gmail.com> Date: Mon Feb 18 11:55:52 2019 +0000 Adds note to README about SerializesModels on Jobs commit 71aa7b5 Author: Matt Collins <mlcollins10@users.noreply.github.com> Date: Tue Feb 12 10:54:43 2019 -0700 Improve array of conditions support in DynamoDbQueryBuilder::where() (baopham#180)

Laravel 6.0 Support

1850227

Remove PHP 7.1 Step from Travis

4606cfe

Since PHP 7.1 will no longer be actively maintained after December of this year.

baopham merged commit 6f16f9d into baopham:master Jan 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Laravel 6.0 Support #203

Laravel 6.0 Support #203

dp88 commented Sep 4, 2019 •

edited

Loading

BenSampo commented Sep 5, 2019

reececomo commented Sep 27, 2019

dp88 commented Oct 2, 2019

reececomo commented Oct 3, 2019

scrutinizer-notifier commented Oct 3, 2019

reececomo commented Oct 11, 2019

crynobone commented Oct 11, 2019

dp88 commented Oct 11, 2019

reececomo commented Oct 14, 2019

gilbertronaldo commented Nov 5, 2019

lamungu commented Nov 14, 2019

a-kova commented Dec 10, 2019

reececomo commented Dec 11, 2019

JackPriceBurns commented Jan 21, 2020

reececomo commented Jan 21, 2020

reececomo commented Jan 21, 2020

crynobone commented Jan 21, 2020

JackPriceBurns commented Jan 21, 2020 •

edited

Loading

baopham commented Jan 21, 2020

baopham commented Jan 21, 2020

baopham commented Jan 21, 2020

BenSampo commented Jan 21, 2020

dp88 commented Jan 21, 2020

reececomo commented Jan 22, 2020

Laravel 6.0 Support #203

Laravel 6.0 Support #203

Conversation

dp88 commented Sep 4, 2019 • edited Loading

BenSampo commented Sep 5, 2019

reececomo commented Sep 27, 2019

dp88 commented Oct 2, 2019

reececomo commented Oct 3, 2019

scrutinizer-notifier commented Oct 3, 2019

reececomo commented Oct 11, 2019

crynobone commented Oct 11, 2019

dp88 commented Oct 11, 2019

reececomo commented Oct 14, 2019

gilbertronaldo commented Nov 5, 2019

lamungu commented Nov 14, 2019

a-kova commented Dec 10, 2019

reececomo commented Dec 11, 2019

JackPriceBurns commented Jan 21, 2020

reececomo commented Jan 21, 2020

reececomo commented Jan 21, 2020

crynobone commented Jan 21, 2020

JackPriceBurns commented Jan 21, 2020 • edited Loading

baopham commented Jan 21, 2020

baopham commented Jan 21, 2020

baopham commented Jan 21, 2020

BenSampo commented Jan 21, 2020

dp88 commented Jan 21, 2020

reececomo commented Jan 22, 2020

dp88 commented Sep 4, 2019 •

edited

Loading

JackPriceBurns commented Jan 21, 2020 •

edited

Loading