Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connection name to be gathered dynamically #236

Merged

Conversation

xengulai
Copy link

Current functionality in the DynamoDbModel uses the property "connection" instead of calling the "getConnectionName()" method. This adds that functionality.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@JackPriceBurns JackPriceBurns merged commit 5f72c16 into baopham:master Feb 18, 2021
hipsterjazzbo added a commit to hipsterjazzbo/laravel-dynamodb that referenced this pull request Jun 12, 2021
commit fe56587
Merge: 5f72c16 3833ac8
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Thu Feb 18 11:49:07 2021 +0000

    Merge pull request baopham#234 from stancl/patch-1

    Improve installation instructions

commit 5f72c16
Merge: 2c7cba9 8827e04
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Thu Feb 18 11:46:46 2021 +0000

    Merge pull request baopham#236 from xengulai/getClientDynamicConnectionName

    Allow connection name to be gathered dynamically

commit 8827e04
Author: Jaysen Nuttall <j.nuttall@plansight.com>
Date:   Mon Feb 15 15:48:25 2021 -0700

    Allow connection name to be gathered dynamically

commit 3833ac8
Author: Samuel Štancl <samuel.stancl@gmail.com>
Date:   Fri Jan 8 20:03:30 2021 +0100

    Improve installation instructions

commit 2c7cba9
Merge: ae85c92 587ede8
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Wed Sep 30 11:45:19 2020 +0100

    Merge pull request baopham#230 from baopham/hotfix/travis-fix

    Fix issues with travis ci

commit 587ede8
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Wed Sep 30 11:38:37 2020 +0100

    Fix issues with travis ci

commit ae85c92
Merge: e5290d8 387a5e9
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Wed Sep 30 11:26:52 2020 +0100

    Merge pull request baopham#225 from alfredkoncsag/patch-1

    Update README.md

commit e5290d8
Merge: 0d12b73 b9217ae
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Wed Sep 30 11:22:56 2020 +0100

    Merge pull request baopham#226 from fd-automox/7.4-fix

    Fix an invalid array access and enable CI for PHP 7.4

commit 0d12b73
Merge: cab7a95 57510e2
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Wed Sep 30 09:29:46 2020 +0100

    Merge pull request baopham#227 from aislandener/patch-1

    Documentation of Where clause with error

commit cab7a95
Merge: 3c85a7b aaf8068
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Wed Sep 30 09:23:19 2020 +0100

    Merge pull request baopham#229 from madeITBelgium/patch-1

    Add support for Laravel 8

commit aaf8068
Author: Made I.T <info@madeit.be>
Date:   Tue Sep 15 22:24:24 2020 +0200

     Add support for Laravel 8

commit 57510e2
Author: Aislan Dener Souza Vicentini <aislandenersouzavicentini@gmail.com>
Date:   Tue Aug 11 09:26:07 2020 -0300

    Documentation of Where clause with error

    In the Where AND and OR documentation part there was no comma between the second and third parameters

commit b9217ae
Author: Fred Dysart <fred.dysart@automox.com>
Date:   Sat Aug 8 11:56:13 2020 -0600

    Be consistent with how the type is accessed

commit c054ebb
Author: Fred Dysart <fred.dysart@automox.com>
Date:   Sat Aug 8 11:41:00 2020 -0600

    Fix an invalid array access and enable CI for PHP 7.4

commit 387a5e9
Author: alfredkoncsag <koncsagalfred@gmail.com>
Date:   Thu Aug 6 12:25:03 2020 +0200

    Update README.md

    Fix query index

commit 3c85a7b
Author: Pele <peleodiase@yahoo.co.uk>
Date:   Mon Mar 23 04:46:28 2020 +0000

    Add support for Laravel 7 (baopham#218)

commit a656c26
Author: Tudor-Dan Ravoiu <tudor2004@yahoo.com>
Date:   Mon Mar 23 06:46:07 2020 +0200

    Fix PHP ^7.4 Notice:  Trying to access array offset on value of type null (baopham#217)

    It seems that under PHP ^7.4 this check is throwing an notice when trying to run a query without using primary/composite key as filter attributes (so when trying to run a DynamoDB scan). This fix checks if the key is set and uses null otherwise.

commit b442ad5
Author: Gustave P <56343436+guspio@users.noreply.github.com>
Date:   Sat Feb 1 05:01:31 2020 +0100

    Changed version system for Laravel 6 (baopham#216)

commit bc58f54
Author: Jack Price-Burns <JackPriceBurns@outlook.com>
Date:   Tue Jan 21 15:12:40 2020 +0000

    Update readme to fix issue with facades (baopham#214)

commit 6f16f9d
Author: David Palmer <dp88@users.noreply.github.com>
Date:   Tue Jan 21 10:00:47 2020 -0500

    Laravel 6.0 Support (baopham#203)

    * Laravel 6.0 Support

    * Remove PHP 7.1 Step from Travis

    Since PHP 7.1 will no longer be actively maintained after December of this year.

commit 77239f9
Author: footballencarta <footballencarta@users.noreply.github.com>
Date:   Fri Mar 22 15:04:47 2019 -0400

    Updated to run with Laravel 5.8 and fix tests (baopham#194)

commit d080e78
Merge: af4f908 c17c2f9
Author: Bao Pham <gbaopham@gmail.com>
Date:   Thu Mar 21 23:28:10 2019 +0800

    Merge pull request baopham#193 from sahilsharma011/patch-1

    Update docs for find and findMany functions

commit c17c2f9
Author: Sahil Sharma <sahilsharma011@users.noreply.github.com>
Date:   Fri Mar 8 15:37:16 2019 +0530

    Update docs for find and findMany functions

    I wanted to use batchGetItem method using this package, but I was not able to find any function in docs which provided this functionality. When I went into the code, I found that there was already a function using batchGetItem method, but it was not listed in the docs.
    So I wanted to update the docs to make it clear.

commit af4f908
Merge: 45bd597 05c0275
Author: Bao Pham <gbaopham@gmail.com>
Date:   Mon Feb 25 22:38:57 2019 +0800

    Merge pull request baopham#190 from sahilsharma011/removeIsNotEmpty

    Change isNotEmpty to isEmpty

commit 05c0275
Author: Sahil Sharma <sahilsharma011@gmail.com>
Date:   Mon Feb 25 14:43:06 2019 +0530

    Change isNotEmpty to isEmpty

commit 45bd597
Merge: 71aa7b5 a470c15
Author: Bao Pham <gbaopham@gmail.com>
Date:   Fri Feb 22 14:23:38 2019 +0800

    Merge pull request baopham#187 from thomasedwards/patch-1

    Adds note to README about SerializesModels on Jobs

commit a470c15
Author: Thomas Edwards <thomas.edwards@gmail.com>
Date:   Mon Feb 18 12:06:52 2019 +0000

    Adds spaces to EOL for Markdown formatting

commit 37436a9
Author: Thomas Edwards <thomas.edwards@gmail.com>
Date:   Mon Feb 18 11:55:52 2019 +0000

    Adds note to README about SerializesModels on Jobs

commit 71aa7b5
Author: Matt Collins <mlcollins10@users.noreply.github.com>
Date:   Tue Feb 12 10:54:43 2019 -0700

    Improve array of conditions support in DynamoDbQueryBuilder::where() (baopham#180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants