Adds datatypes support. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {ok, "204", _H, _B} -> | ||
| %% not creation, no returnbody | ||
| ok; | ||
| {ok, "200", _H, Body} -> |
There was a problem hiding this comment.
No case clause match for return_body updates, assuming it is the reuse of the Body here (as it is already bound above as the JSON to be posted at line 683.) Same below for the 201 case.
I pushed the fix.
|
Looks good to me. Pushed a minor fix. Tested by hand in some trivial cases. A riak_test that exercises this client would be great, and helpful for riak_kv#732 too. 👍 |
|
Good catch, Russell, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also basho/riak_kv#732. The API functions are equivalent to the ones provided by the PB client, but return values for errors will obviously be slightly different.