Add HTTP API for datatypes. #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ctx#ctx{client=Client, | ||
| bucket=path_segment_to_bin(bucket, RD), | ||
| key=path_segment_to_bin(key, RD), | ||
| crdt_type=proplists:get_value(crdt, wrq:path_info(RD)), |
There was a problem hiding this comment.
I thought this came from the bucket_type now (that the path segment was just the string "datatypes")? Should this still be in the code?
There was a problem hiding this comment.
You're right, I missed this.
* Remove extraction of undefined path segment into the resource context. * Guard the timeout parameter check to make sure it is greater than 0. * Add explanatory comment about the redirection when using the default bucket-type.
| {Result, RD, Ctx}; | ||
| TimeoutStr when is_list(TimeoutStr) -> | ||
| try list_to_integer(TimeoutStr) of | ||
| Timeout when is_integer(Timeout), Timeout > 0 -> |
There was a problem hiding this comment.
Did you figure out if > 0 is correct? I wonder if >= 0 is better, as you say, then 0 can mean infinity?
There was a problem hiding this comment.
I think in the other APIs, yes 0 means infinity, but this doesn't coerce it. Fixing.
|
Ran eunit tests and tested by hand using riak-erlang-http-client#28. |
seancribbs
pushed a commit
that referenced
this pull request
Nov 25, 2013
Add HTTP API for datatypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites
riak_kv_wm_crdtand ensures that the functionality it exposes is similar to PB. The JSON format of request/response payloads is described in detail at the top of the module, and implemented inriak_kv_crdt_json.