Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of instrumentation issues that occur when other projects use the fuzzing rules. #91

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Fix a number of instrumentation issues that occur when other projects use the fuzzing rules. #91

merged 4 commits into from
Dec 8, 2020

Conversation

stefanbucur
Copy link
Collaborator

  • The build flags need to be referenced with the absolute workspace name, so the names resolve correctly when imported in a different repo.
  • The fuzzing build mode is now optional so it can be disabled in the projects that wish so.

@stefanbucur
Move the libfuzzer linkopts to the stub cc_library, such that only th…
4f58d0c 
…e top-level fuzz test is instrumented.

Without this change, any other binary that may be built on the transitive dependency chain will also get linked with libFuzzer, resulting in a linker error (duplicate main functions).
@stefanbucur
Fix libFuzzer's copts.
81f41fa
@stefanbucur
Fix typo in stub output.
3dc40ac
@stefanbucur
Fix a number of instrumentation issues.
c5520b0 
* The build flags need to be referenced with the absolute workspace name, so the names resolve correctly when imported in a different repo.
* The fuzzing build mode is now optional so it can be disabled in the projects that wish so.
@stefanbucur stefanbucur mentioned this pull request Dec 7, 2020
Closed
Base automatically changed from libfuzzer-linkopts to master December 8, 2020 02:15
@stefanbucur stefanbucur merged commit c72ed72 into master Dec 8, 2020
@stefanbucur stefanbucur deleted the envoy-integration branch December 8, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chabiraabdelaziz chabiraabdelaziz chabiraabdelaziz approved these changes

@oliverchang oliverchang oliverchang approved these changes

@asraa asraa Awaiting requested review from asraa asraa is a code owner

@inferno-chromium inferno-chromium Awaiting requested review from inferno-chromium inferno-chromium is a code owner

@markus-kusano markus-kusano Awaiting requested review from markus-kusano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanbucur @oliverchang @chabiraabdelaziz