Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of instrumentation issues that occur when other projects use the fuzzing rules. #91

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Fix a number of instrumentation issues that occur when other projects use the fuzzing rules. #91

merged 4 commits into from
Dec 8, 2020

Commits on Dec 6, 2020

  1. Move the libfuzzer linkopts to the stub cc_library, such that only th… 

    …e top-level fuzz test is instrumented.

Without this change, any other binary that may be built on the transitive dependency chain will also get linked with libFuzzer, resulting in a linker error (duplicate main functions).
    @stefanbucur
    stefanbucur committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    4f58d0c View commit details
    Browse the repository at this point in the history

  2. Fix libFuzzer's copts.

    @stefanbucur
    stefanbucur committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    81f41fa View commit details
    Browse the repository at this point in the history

  3. Fix typo in stub output.

    @stefanbucur
    stefanbucur committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    3dc40ac View commit details
    Browse the repository at this point in the history

  4. Fix a number of instrumentation issues. 

    * The build flags need to be referenced with the absolute workspace name, so the names resolve correctly when imported in a different repo.
* The fuzzing build mode is now optional so it can be disabled in the projects that wish so.
    @stefanbucur
    stefanbucur committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    c5520b0 View commit details
    Browse the repository at this point in the history