Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JVM perfdata when stamping jars #988

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

cheister
Copy link
Collaborator

A recent JDK update started printing the following warning message from the JVM

[warning][perf,memops] Cannot use file /tmp/hsperfdata_username/2 because it is locked by another process (errno = 11)

on linux hosts. Also referenced from bazelbuild/bazel#3236

This PR disables the perfdata generation when stamping a jar so we won't get this warning message, which is printed for every jar that processed.

@@ -3,6 +3,7 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
java_binary(
name = "AddJarManifestEntry",
srcs = ["AddJarManifestEntry.java"],
jvm_flags = ["-XX:-UsePerfData"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment on why this flag is necessary?

@cheister cheister merged commit be4bc31 into bazel-contrib:master Oct 27, 2023
8 checks passed
@cheister cheister deleted the no-perfdata branch October 27, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants