Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bzlmod. #224

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Migrate to Bzlmod. #224

merged 1 commit into from
Jan 26, 2024

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Dec 1, 2023

This updates Bazel to 7.0.1.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-bzlmod branch 5 times, most recently from eb1a010 to c817cbb Compare December 1, 2023 01:59
@SanjayVas
Copy link
Member Author

Note that the [warning][perf,memops] Cannot use file /tmp/hsperfdata_user/2 because it is locked by another process (errno = 11) message can be safely ignored. It will be removed once we upgrade to a release of rules_jvm_external that includes bazel-contrib/rules_jvm_external#988

@SanjayVas SanjayVas force-pushed the sanjayvas-bzlmod branch 7 times, most recently from a2494c9 to 4cbaeae Compare December 7, 2023 22:59
@SanjayVas SanjayVas changed the base branch from main to sanjayvas-rules_oci December 7, 2023 22:59
@SanjayVas SanjayVas force-pushed the sanjayvas-rules_oci branch 4 times, most recently from 8230ba4 to 4f94f08 Compare December 11, 2023 18:49
@SanjayVas SanjayVas force-pushed the sanjayvas-bzlmod branch 2 times, most recently from 5331dee to e23f85c Compare December 12, 2023 00:18
Base automatically changed from sanjayvas-rules_oci to main December 12, 2023 18:09
@SanjayVas SanjayVas force-pushed the sanjayvas-bzlmod branch 2 times, most recently from 1c3da45 to db1a326 Compare December 21, 2023 01:01
@SanjayVas SanjayVas changed the base branch from main to sanjayvas-tink December 21, 2023 01:02
@SanjayVas SanjayVas force-pushed the sanjayvas-bzlmod branch 3 times, most recently from 763c543 to 42624d9 Compare December 21, 2023 19:03
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 156 files reviewed, all discussions resolved (waiting on @YuhongWang-Amazon)


src/main/kotlin/org/wfanet/measurement/gcloud/spanner/testing/SpannerEmulator.kt line 87 at r2 (raw file):

        val readyMessage = "Server address: $emulatorHost"

        emulator.errorStream.use { input ->

Spanner emulator made some minor changes to its output

This updates Bazel to 6.4.0 and Tink to 1.8.0.
Copy link
Contributor

@YuhongWang-Amazon YuhongWang-Amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 102 of 132 files at r1, 52 of 54 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit 3aa5f36 into main Jan 26, 2024
3 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-bzlmod branch January 26, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants