image.sh.tpl is too unhermetically hermetic!

[GregBowyer]

I suspect this is rendered moot by #459, but.

We run an aggressive hermetic setup on top of NixOS, I suspect this might happen for others who are being highly hermetic.

Presently, image.bzl is as follows:

    ctx.actions.run(
        inputs = depset(transitive = inputs_depsets),
        arguments = [args],
        outputs = [output],
        env = action_env,
        executable = util.maybe_wrap_launcher_for_windows(ctx, launcher),
        tools = [crane.crane_info.binary, registry.registry_info.launcher, registry.registry_info.registry, jq.jqinfo.bin],
        mnemonic = "OCIImage",
        progress_message = "OCI Image %{label}",
    )

This fails as Bazel wipes out $PATH and as a result, mktemp (and well everything) is basically none functional.

It appears that adding in the dreaded use_default_shell_env = True fixes this.

[rickvanprim]

That should be fixed by #459. Apologies for the slow progress.

[GregBowyer]

No, it's all good, getting hermetic is hard, and it's fun to learn what is not a shell built-in ;)

We did a hack for now on the rules, but will track for the cleaner fix you are building,

[thesayyn]

will be fixed by #569

[thesayyn]

fixed by #569