Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated image.sh.tpl and tarball.sh.tpl to use hermetic tools. #459

Closed

Conversation

rickvanprim
Copy link
Contributor

@rickvanprim rickvanprim commented Jan 12, 2024

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this overlaps with #385 which I haven't landed because it's a breaking change. It looks like this one isn't though - it works with current versions of dependencies.

@alexeagle
Copy link
Collaborator

Oh I see, it's certainly breaking as it assumes some bazel-lib changes that haven't landed yet.

@rickvanprim
Copy link
Contributor Author

Yes this is dependent on the other PR. I updated this PR description to reflect that. What's the policy around updating the version of aspect_bazel_lib that rules_oci depends on?

@alexeagle
Copy link
Collaborator

That's where #385 got blocked - unless we backport things to bazel-lib 1.x, we are treating it as a breaking change for rules_oci to require bazel-lib 2.x.

@rickvanprim
Copy link
Contributor Author

I haven't tried, but presumably I could open another PR in aspect_bazel_lib against the 1.x branch, as the changes to add those toolchains are all pretty self contained.

@thesayyn
Copy link
Collaborator

Now, both oci_image and oci_tarball is using hermetic tools. Closing this.

@thesayyn thesayyn closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants