refactor: use hermetic tar #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
bazel-lib_tar
branch
2 times, most recently
from
eb2ccf0
to
e1a871e
Compare
|
hitting a bug in bazel-lib, sent bazel-contrib/bazel-lib#574 |
alexeagle
force-pushed
the
bazel-lib_tar
branch
from
17ac718
to
85e619c
Compare
alexeagle
force-pushed
the
bazel-lib_tar
branch
from
85e619c
to
c532892
Compare
alexeagle
force-pushed
the
bazel-lib_tar
branch
from
79f65ad
to
57c697a
Compare
thesayyn
reviewed
Oct 4, 2023
|
Thanks @alexeagle , I checked the latest version, works good for my usecase. |
thesayyn
reviewed
Oct 4, 2023
|
Are there any automated tests that could be extended with checks for this new feature (e.g. gid, uid, time)? |
Closed
alexeagle
force-pushed
the
bazel-lib_tar
branch
from
7383f9f
to
8036ab1
Compare
Closed
|
Looks like |
Forcing users to upgrade to bazel-lib 2.0 is a breaking change, so we're planning to start a 2.x branch here where this can land. |
|
When using this branch, it fails with this kind of error: It started happening just recently. It seems there is a new version for this deb... And there is a newer version of bazel-lib (2.5.0), which makes it work. |
Strum355
reviewed
Mar 11, 2024
Strum355
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Mar 11, 2024
Workaround for https://github.com/sourcegraph/devx-support/issues/622. This is portable between both bsdtar and gnutar. On gnutar, this is the default, so this changes nothing for CI builds. This only changes behaviour in macOS with bsdtar. It is unclear to me where a final solution will exist: - An issue was opened upstream in docker/moby, but the latest opinion is that this is an issue with rules_oci _technically_ emitting docker-compatible formats that are incompatible with docker (Im not 100% sure yet that docker itself cant create a tarball that would fail to `docker load`, but I dont want to subject Christoph to more experiments lol) moby/moby#47517 - A PR exists in rules_oci to use a hermetic BSD tar instead of system tar (doesnt work on nixos though coz dynamic libraries :sadge:). It uses `mtree` format to add files, I don't know yet if that works around xattr issue without also passing `--no-xattr` (my current belief is that it does not) bazel-contrib/rules_oci#385 ## Test plan Had Christoph run `bazel run //cmd/batcheshelper:image_tarball`, which succeeded with this patch
honnix
reviewed
Mar 19, 2024
Fixes #328 fix: supply mtree file for determinism fix: set tar content times to beginning of this year avoids some tools thinking that 1970 is 'too old' refactor: extract function for mtree lines refactor: cleanup STAGING_DIR chore: bump to bazel-lib 2.0rc chore: remove bazel 5 workaround Bazel-lib 2.0 doesn't include this anymore chore: upgrade stardoc to match bzlmod version ci: test on bazel 7 rather than 5
alexeagle
force-pushed
the
bazel-lib_tar
branch
2 times, most recently
from
ebf4b0b
to
d204496
Compare
alexeagle
force-pushed
the
bazel-lib_tar
branch
from
d204496
to
3f0ee64
Compare
thesayyn
approved these changes
Apr 26, 2024
alexeagle
added a commit
that referenced
this pull request
May 16, 2024
Partial back-port of #385 from the 2.x branch
alexeagle
added a commit
that referenced
this pull request
May 16, 2024
Partial back-port of #385 from the 2.x branch
thesayyn
pushed a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this shouldn't land until bazel-lib 2.0 is stable (RC or ideally final)