This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
bazel: patch rules_oci to run tar with --no-xattrs #61004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for https://github.com/sourcegraph/devx-support/issues/622. This is portable between both bsdtar and gnutar. On gnutar, this is the default, so this changes nothing for CI builds. This only changes behaviour in macOS with bsdtar.
It is unclear to me where a final solution will exist:
docker load
, but I dont want to subject Christoph to more experiments lol)docker load
fails with lsetxattr com.apple.provenance /manifest.json: operation not supported on Ventura & later moby/moby#47517mtree
format to add files, I don't know yet if that works around xattr issue without also passing--no-xattr
(my current belief is that it does not) refactor: use hermetic tar bazel-contrib/rules_oci#385Test plan
Had Christoph run
bazel run //cmd/batcheshelper:image_tarball
, which succeeded with this patch