Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules_jni 0.4.0 #61

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 11, 2022

No description provided.

@fmeum
Copy link
Contributor Author

fmeum commented Jan 11, 2022

@meteorcloudy At least some of these issues seem real and interesting. I will take a look on my end.

@fmeum fmeum marked this pull request as draft January 12, 2022 08:49
@fmeum fmeum force-pushed the rules_jni-0.3.1-add-tests branch 3 times, most recently from 2205d92 to a3fa266 Compare January 12, 2022 10:30
@fmeum fmeum force-pushed the rules_jni-0.3.1-add-tests branch from a3fa266 to 89a036c Compare January 12, 2022 10:31
@fmeum fmeum changed the title [rules_jni] Add module-based presubmit tests Add rules_jni 0.4.0 Jan 12, 2022
@fmeum fmeum marked this pull request as ready for review January 12, 2022 10:32
@fmeum
Copy link
Contributor Author

fmeum commented Jan 12, 2022

@meteorcloudy I had to fix some things upstream and thus am now adding a new version rather than modifying presubmit.yml for the existing version.

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@meteorcloudy meteorcloudy merged commit 147ae87 into bazelbuild:main Jan 12, 2022
@fmeum fmeum deleted the rules_jni-0.3.1-add-tests branch June 8, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants