-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCR presubmit: support specify a test module #1302
Comments
/cc @fmeum @alexeagle What do you think of this? |
Looks good to me. I like that this now has the same format as the top-level test config, just one level deeper in. |
meteorcloudy
added a commit
that referenced
this issue
Jan 11, 2022
BCR modules can now specify task configurations for a test module under `bcr_test_module`. Closes: #1302
meteorcloudy
added a commit
that referenced
this issue
Jan 11, 2022
BCR modules can now specify task configurations for a test module under `bcr_test_module`. Closes: #1302
This is now implemented, @fmeum feel free to try it out and give us feedback! |
I am giving it a try in bazelbuild/bazel-central-registry#61 |
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this issue
Dec 10, 2023
BCR modules can now specify task configurations for a test module under `bcr_test_module`. Closes: bazelbuild#1302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context: https://groups.google.com/a/bazel.build/g/external-deps/c/GcV1cpRd-Ls/m/1UU9Ez_DDQAJ
In the presubmit.yml file, allow BCR modules to specify a test module (with
bcr_test_module
,module_path
and its task configurations) to verify the basic functionalities of the checked-in module. The top level of task configurations are only used to verify the build targets.#1300 makes the configuration file simpler.
Example (meteorcloudy/bazel-central-registry#7):
The text was updated successfully, but these errors were encountered: